Skip to content

Conversation

@samer-stripe
Copy link
Collaborator

Summary

Remove IntentConfirmationInterceptor interface from CustomerSheetSetupIntentInterceptor

Motivation

Not needed for this interceptor

Testing

  • Added tests
  • Modified tests
  • Manually verified

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   2.1 MiB │   2.1 MiB │  0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │   1.1 MiB │   1.1 MiB │  0 B │   1.1 MiB │   1.1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 303.5 KiB │ 303.5 KiB │  0 B │ 457.7 KiB │ 457.7 KiB │  0 B 
   native │   7.9 MiB │   7.9 MiB │  0 B │  19.3 MiB │  19.3 MiB │  0 B 
    asset │   7.7 KiB │   7.7 KiB │  0 B │   7.5 KiB │   7.5 KiB │  0 B 
    other │  95.6 KiB │  95.6 KiB │ -8 B │ 183.6 KiB │ 183.6 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  11.5 MiB │  11.5 MiB │ -8 B │  25.4 MiB │  25.4 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20721 │ 20721 │ 0 (+0 -0) 
   types │  6513 │  6513 │ 0 (+0 -0) 
 classes │  5277 │  5277 │ 0 (+0 -0) 
 methods │ 31557 │ 31557 │ 0 (+0 -0) 
  fields │ 18290 │ 18290 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  163 │  163 │  0   
 entries │ 3667 │ 3667 │  0
APK
    compressed    │  uncompressed   │                     
──────────┬───────┼──────────┬──────┤                     
 size     │ diff  │ size     │ diff │ path                
──────────┼───────┼──────────┼──────┼─────────────────────
 29.2 KiB │ -11 B │ 64.6 KiB │  0 B │ ∆ META-INF/CERT.SF  
  1.2 KiB │  +3 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA 
──────────┼───────┼──────────┼──────┼─────────────────────
 30.4 KiB │  -8 B │ 65.9 KiB │  0 B │ (total)

@samer-stripe samer-stripe marked this pull request as ready for review November 28, 2025 16:57
@samer-stripe samer-stripe requested review from a team as code owners November 28, 2025 16:57
@samer-stripe samer-stripe force-pushed the samer/customer-sheet-setup-interceptor-remove-interface branch from ea2fe17 to e94aab3 Compare November 28, 2025 17:27
@samer-stripe samer-stripe merged commit 1ba3b99 into master Nov 30, 2025
19 checks passed
@samer-stripe samer-stripe deleted the samer/customer-sheet-setup-interceptor-remove-interface branch November 30, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants