Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New architecture support #848

Open
fobos531 opened this issue Nov 11, 2024 · 6 comments
Open

New architecture support #848

fobos531 opened this issue Nov 11, 2024 · 6 comments
Labels
dependencies Pull requests that update a dependency file next release

Comments

@fobos531
Copy link

fobos531 commented Nov 11, 2024

Is your feature request related to a problem? Please describe.

RN 0.76 is officially out and it enables new architecture by default.

Describe the solution you'd like

This library should properly support new architecture, otherwise users are forced to disable new architecture.

@nazli-stripe
Copy link
Collaborator

We are aiming to add new architecture support in early 2025.

@nazli-stripe nazli-stripe added dependencies Pull requests that update a dependency file next release labels Nov 18, 2024
@Brunowilliang
Copy link

@nazli-stripe, I've tested it and the terminal is working with the new architecture. Is there a problem that justifies opening this issue?

@nazli-stripe
Copy link
Collaborator

@Brunowilliang we haven't tested it so don't want to officially claim support for it, and it is in our plans to upgrade our underlying RN version to 0.76. Everything was working fine in your testing?

@fobos531 did you run into issues?

@Brunowilliang
Copy link

yes, it worked for me @nazli-stripe, in order for it to work I had to adjust a few things in ‘expo-build-properties’, but it worked...

	[
		'expo-build-properties',
		{
			android: {
				minSdkVersion: 26,
				compileSdkVersion: 35,
				targetSdkVersion: 35,
				packagingOptions: {
					pickFirst: ['org/bouncycastle/x509/CertPathReviewerMessages*'],
					exclude: [
						'org/bouncycastle/pqc/crypto/picnic/lowmcL5.bin.properties',
						'org/bouncycastle/pqc/crypto/picnic/lowmcL3.bin.properties',
						'org/bouncycastle/pqc/crypto/picnic/lowmcL1.bin.properties',
					],
				},
			},
			ios: {
				deploymentTarget: '15.1',
			},
		},
	],

I don't know if I can do that, but I managed to make it work 🤣

@Salman-Usmani
Copy link

I faced an issue with CardForm (which I must use to get a token), when newArch is enabled the onFormComplete callback doesn’t trigger, and the UI behaves inconsistently—sometimes asking for a ZIP code and sometimes not.
hope it helps and we get to see newArch soon...

@nazli-stripe
Copy link
Collaborator

hey @Salman-Usmani is it possible you mean https://github.com/stripe/stripe-react-native? We don't have CardForm in this library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file next release
Projects
None yet
Development

No branches or pull requests

4 participants