Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same tsc settings as in loopback-next #50

Open
bajtos opened this issue Apr 19, 2017 · 3 comments
Open

Use same tsc settings as in loopback-next #50

bajtos opened this issue Apr 19, 2017 · 3 comments

Comments

@bajtos
Copy link
Member

bajtos commented Apr 19, 2017

Once loopbackio/loopback-next#174 is done and published, we should start following LoopBack.next conventions in this project too.

As a short-term workaround, we may want to copy (duplicate) tslint config files and the relevant parts of tsconfig.

cc @superkhau @ritch

@dhmlau
Copy link
Member

dhmlau commented Apr 6, 2018

@bajtos , is it still valid?

@virkt25
Copy link
Contributor

virkt25 commented Apr 9, 2018

I don't think so since this project now uses @loopback/build

@bajtos bajtos changed the title Use same tslint and tsc settings as in loopback-next Use same tsc settings as in loopback-next Apr 27, 2018
@bajtos
Copy link
Member Author

bajtos commented Apr 27, 2018

AFAICT, we are using tslint configuration from @loopback/build (see tslint.json), but we are not using the shared typescript config yet (see tsconfig.json).

I have edited the issue to reflect the fact that it's only tsconfig to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants