Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build report tab seems to not become visible in multi-stage YAML #32

Closed
rouke-broersma opened this issue May 19, 2020 · 10 comments · Fixed by #62
Closed

Build report tab seems to not become visible in multi-stage YAML #32

rouke-broersma opened this issue May 19, 2020 · 10 comments · Fixed by #62
Labels
bug Something isn't working

Comments

@rouke-broersma
Copy link
Member

No description provided.

@rouke-broersma rouke-broersma added the bug Something isn't working label May 19, 2020
@robertlyson
Copy link

@Mobrockers any suggestions on where I need to look to prepare a fix?

@rouke-broersma
Copy link
Member Author

rouke-broersma commented Jun 4, 2020

@robertlyson the most likely places would be either for yaml pipelines there is a different contribution extension point (target:

) than for legacy builds, or the supportstask works differently for yaml pipelines (
"supportsTasks": ["44d9cfb7-7efd-48e2-b2ae-4750950271be"],
).

Perhaps you could look into the extension docs to see if you can dig up anything about those two things. That's where I would start.

@robertlyson
Copy link

@rouke-broersma
Copy link
Member Author

rouke-broersma commented Jun 5, 2020

Awesome finds :)

I am especially interested in that dynamic keyword used by protractor and what it does. They also have support for multiple reports which is something we also need, so that should help very much in figuring out how to get this working!

Are you interested in giving it a shot or do you think that's a bit much as a first contribution?

If you are interested, this repo should be mostly setup to be able to live debug the web extension I think but I haven't tested it. This blog post describes how it should be set up to be able to run the web extension locally without uploading to azure devops: https://github.com/microsoft/azure-devops-extension-hot-reload-and-debug

Then, if you want to try out the extension in an actual azure devops, you're gonna have to set up a publisher account at https://marketplace.visualstudio.com/manage, upload the extension as private (using a different extension id) and share the extension with your own private azure devops somewhere.

Actually looking at that blog again I slightly misunderstood how the local development setup works. I should probably create some step by step documentation to get that whole setup working.

@robertlyson
Copy link

@Mobrockers thanks for the resources, that will make my contribution easier, will give it a try over the weekend :)

@rouke-broersma
Copy link
Member Author

If you have any questions I should be available this weekend. You can contact me here or on our slack.

@robertlyson
Copy link

@Mobrockers I was only able to publish a test extension package but couldn't debug it locally yet. If you like you can give the issue try, if not I'm happy to continue my investigation over the next weekend. I just wanted to share my update.

@rouke-broersma
Copy link
Member Author

Thanks for the update!

@rouke-broersma
Copy link
Member Author

Hi @robertlyson

I think the biggest issue was actually in the deployment itself. I had set updateTasksId: true, which generates the task id's based on the publisher and extension name. I had not used this when testing, but added it as part of the public release when I added a proper release pipeline for the extension..

Turns out when you change task id's in the pipeline, and those task id's are used for the 'contributingtask' section, those are not changed.. :/ Which means there was a mismatch and the tab never became visible. Which also means this issue was probably not only with YAML pipelines but with all pipelines... 🤦‍♀️

I'm soon releasing a new version which should fix this problem.

@robertlyson
Copy link

@Mobrockers glad you figured it out. Many thanks for fixing the issue 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants