Skip to content
This repository has been archived by the owner on May 14, 2021. It is now read-only.

Deprecated package #278

Open
alexander-akait opened this issue Aug 28, 2019 · 10 comments
Open

Deprecated package #278

alexander-akait opened this issue Aug 28, 2019 · 10 comments

Comments

@alexander-akait
Copy link
Contributor

Stylelint support css-in-js out of box, so no need use this plugin, will be great deprecate this

@chinesedfan
Copy link
Member

@evilebottnawi Can you provide more details about it? Is it due to some new features introduced by the latest stylelint?

@alexander-akait
Copy link
Contributor Author

@chinesedfan it is built-in feature since 10 version https://github.com/stylelint/stylelint#features

@chinesedfan
Copy link
Member

@evilebottnawi Looks good. Thanks for your information. I will play it more before giving a final decision. (cc @emilgoldsmith @mxstbr)

@emilgoldsmith
Copy link
Member

Awesome to hear :)

@chinesedfan
Copy link
Member

I was out of the world of stylelint too long. According to stylelint's CHANGLOG,

  • v9.4, introduced syntax: styled to support css-in-js, which was based on postcss-styled
  • v9.10, replaced postcss-styled with the more powerful postcss-jsx and changed the option as syntax: css-in-js
  • v10.0, removed the deprecated syntax: styled completely

After read some codes of postcss-jsx, I think it is the better way to lint styled-components files, even thought it still has lots of differences with this processor. Because it analyzes the whole AST more completely and can give more accurate replacements for tagged template interpolations. In later days, I will open issues for postcss-jsx to make this processor's abilities be 100% migrated smoothly.

@mxstbr
Copy link
Member

mxstbr commented Aug 29, 2019

I think that's a great idea

@alexander-akait
Copy link
Contributor Author

@chinesedfan friendly ping, what is status?

@chinesedfan
Copy link
Member

@evilebottnawi I have opened gucong3000/postcss-jsx#62. But not sure when @gucong3000 or somebody else has time to solve them.

@alexander-akait
Copy link
Contributor Author

Thanks!

bigpopakap pushed a commit to bigpopakap-crap/shared-node-tools that referenced this issue Jan 23, 2020
…ts preprocessor

this package was apparently deprecated because stylelint now supports preprocessors out of the box: styled-components/stylelint-processor-styled-components#278
bigpopakap pushed a commit to bigpopakap-crap/shared-node-tools that referenced this issue Jan 23, 2020
this package was apparently deprecated because stylelint now supports preprocessors out of the box: styled-components/stylelint-processor-styled-components#278
bigpopakap pushed a commit to bigpopakap-crap/shared-node-tools that referenced this issue Jan 23, 2020
this package was apparently deprecated because stylelint now supports preprocessors out of the box: styled-components/stylelint-processor-styled-components#278
@koba04
Copy link

koba04 commented Oct 1, 2020

What's the current status of this project?

styled-components recommends using this for stylelint, so many developers would think that using this processor with stylelint is an official way to use stylelint with styled-components.
https://styled-components.com/docs/tooling#stylelint

But this still uses the old version of Babel, so we cannot use new ES syntaxes and TypeScript syntaxes with this processor.
#296

This is a pitfall to combined styled-components and stylelint, so I think deprecating this package is an important message for developers.

I think styled-components updates the document, but it's an another issue.
styled-components/styled-components-website#671

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants