Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emmet.showExpandedAbbreviation: never doesn't disable Emmet abbreviation autocomplete #10

Open
karlhorky opened this issue Apr 5, 2023 · 3 comments

Comments

@karlhorky
Copy link

karlhorky commented Apr 5, 2023

Hi there, first of all, thanks for this plugin! Very nice to have CSS features in JS/TS 🙌

I am using this plugin via the vscode-styled-components extension (styled-components/vscode-styled-components#57 introduced Emmet into this extension)

However, I do not want to use Emmet at all. I don't mind if it would just appear and not break my workflow, but it causes some very strange things to happen when typing h1, h2, h3 within a css tagged template literal:

Kapture.2021-11-12.at.21.12.08.mp4

Apparently it should possible to disable Emmet with the settings below (which should work according to the VS Code docs and the typescript-styled-plugin docs)

  "emmet.showExpandedAbbreviation": "never",

However, this doesn't work.

The only way to disable this is with the following settings, which also disables other suggestions:

  "editor.quickSuggestions": {
    "other": false
  }

Originally reported in:

@jasonwilliams
Copy link
Collaborator

jasonwilliams commented Apr 5, 2023

@karlhorky did you want to have a go working on this? It shouldn't be too difficult.
The styled components extension may need to send the setting up into the language server and from there we can choose not to show emmet.

The deno plugin receives an info object which has the config in it. You can see it here:
https://github.com/denoland/vscode_deno/blob/main/typescript-deno-plugin/src/index.ts#L102-L111

This plugin is equivalent so it should be able to receive the same thing

@karlhorky
Copy link
Author

karlhorky commented Apr 6, 2023

I have a bunch of feature work, ongoing projects and then open source work that would come ahead of this unfortunately, but maybe closer to summer / fall 2023 I'll have some time.

@RageCrezz
Copy link

Any updates regarding this issue? Emmet Abbreviations are a pain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants