-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[webpack config] Support .mjs files #1385
Closed
magicmark opened this issue
Jun 19, 2019
· 3 comments
· Fixed by #1386 · May be fixed by rollup-umd/documentation#63
Closed
[webpack config] Support .mjs files #1385
magicmark opened this issue
Jun 19, 2019
· 3 comments
· Fixed by #1386 · May be fixed by rollup-umd/documentation#63
Labels
Comments
magicmark
added a commit
to magicmark/react-styleguidist
that referenced
this issue
Jun 19, 2019
magicmark
added a commit
to magicmark/react-styleguidist
that referenced
this issue
Jun 19, 2019
Makes sense! Feel free to send a pull request 👾 |
Oh, you did already, nice ;-) |
🎉 This issue has been resolved in version 9.1.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The problem
graphql uses
.mjs
files, which when using in a component build with styleguidist produces the following errors:See the following for similar issues:
Why?
Take a look at the
package.json
for graphql - https://unpkg.com/[email protected]/package.jsonIt uses this:
"module": "index.mjs",
It looks we don't support
.mjs
in the base webpack config:react-styleguidist/src/scripts/make-webpack-config.js
Line 45 in 4ef3cc9
Is this a deliberate move not to support mjs files?
Proposed solution
Add
.mjs
back into theresolutions
field, per the defaults:https://webpack.js.org/configuration/resolve/#resolveextensions
Alternative solutions
As suggested: graphql/graphql-js#1272 (comment)
Additional context
From https://github.com/webpack/webpack/releases/tag/v4.0.0:
The text was updated successfully, but these errors were encountered: