Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement typed header parsing for ucan header #68

Closed
cdata opened this issue Sep 30, 2022 · 2 comments
Closed

Implement typed header parsing for ucan header #68

cdata opened this issue Sep 30, 2022 · 2 comments
Labels
Enhancement New user-facing feature Good First Issue Good for newcomers

Comments

@cdata
Copy link
Collaborator

cdata commented Sep 30, 2022

After we integrate support for changes to rs-ucan landing in ucan-wg/rs-ucan#28, we will have to contend with a new world where HTTP request headers that use UCAN-based JWT for authorization may also include auxilliary ucan headers (see: https://github.com/ucan-wg/ucan-as-bearer-token#2-request-headers).

We already benefit from typed header parsing for the authorization header. We should author an extension to the typed headers that are offered by axum to include something to make parsing ucan headers more convenient and consistent.

@blaine
Copy link

blaine commented Aug 5, 2023

If anyone looks to pick this up, we have [almost] an implementation in fission-server that will be extracted to a generic axum extractor. Will update as we get closer. It probably makes sense to implement this as a separate crate from rs-ucan, but appreciate any thoughts on the matter!

ucan-wg/rs-ucan#122

@jsantell
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New user-facing feature Good First Issue Good for newcomers
Projects
Status: 🌱 Done
Development

No branches or pull requests

3 participants