Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

As a user, I want links to transclude the linked content #328

Closed
Tracked by #12
, #535
...
gordonbrander opened this issue Aug 3, 2022 · 1 comment · Fixed by #795
Closed
Tracked by #12
, #535
...

As a user, I want links to transclude the linked content #328

gordonbrander opened this issue Aug 3, 2022 · 1 comment · Fixed by #795
Assignees
@bfollington
Labels
Enhancement New feature or request User Story

Comments

@gordonbrander
Copy link
Collaborator

gordonbrander commented Aug 3, 2022 •
edited
Loading

As a user, I want links to transclude the linked content, so I can treat links as embeds for the content.

Related:
@gordonbrander gordonbrander added the Enhancement New feature or request label Oct 10, 2022
@gordonbrander gordonbrander mentioned this issue Feb 21, 2023
Open
@bdehaynin bdehaynin mentioned this issue Mar 3, 2023
Open
6 tasks
@gordonbrander gordonbrander moved this from 🏔️ Icebox to 📚 Todo in Subconscious + Noosphere Mar 8, 2023
@bfollington bfollington mentioned this issue Mar 20, 2023
Closed
6 tasks
@bfollington bfollington moved this from 📚 Todo to 🧑‍🌾 In Progress in Subconscious + Noosphere Mar 20, 2023
@bfollington bfollington self-assigned this Mar 20, 2023
@bfollington
Copy link
Collaborator

While we've got something working fairly well using TK2 and custom rendering, there is another way I can think to approach rendering transcludes inspired by https://twitter.com/tylerangert/status/1638643087256743936?s=20 (and a rendering accident I had locally).

From our existing layout code, we know the exact on-screen rectangles to render transclude views into. We could add a layer over the top of the text area and place UIKit wrappers around SwiftUI views at the exact positions and dimensions to provide interactive components etc. The main challenge here is that A. it's fiddley and hacky and B. it could interfere with event propagation to the underlying view...

But the upsides are full SwiftUI rendering support including animations etc.

@bfollington bfollington moved this from 🧑‍🌾 In Progress to 📚 Todo in Subconscious + Noosphere Mar 30, 2023
@gordonbrander gordonbrander changed the title Rich transclusions As a user, I want links to transclude the linked content Apr 21, 2023
@gordonbrander gordonbrander mentioned this issue Apr 21, 2023
Closed
42 tasks
@gordonbrander gordonbrander mentioned this issue Apr 23, 2023
Open
21 tasks
@bfollington bfollington mentioned this issue May 5, 2023
Merged
2 tasks
@gordonbrander gordonbrander moved this from 📚 Todo to 🧑‍🌾 In Progress in Subconscious + Noosphere Jun 23, 2023
bfollington added a commit that referenced this issue Jun 27, 2023
@bfollington
Render transclude blocks in MemoDetailViewer (#574)
115a4ab 
Related to #328 
Resolves #324 
Fixes #710

This approach is based on my experiments with rendering in the editor:
#428

# Changes
- Detect slashlinks in subtext blocks
- Fetch transclude previews from the sphere index (SQLite)
- Display inline between blocks
- Translate addresses to match the context
- Tests for fetching local transcludes
    - Difficult to construct a test for 3P content with transcludes

## Own content, own slashlink

<img width="372" alt="image"
src="https://github.com/subconsciousnetwork/subconscious/assets/5009316/5d7fae72-f25f-4ed7-b9b2-78635d34d59a">

## 3P Content, their own slashlink

<img width="373" alt="image"
src="https://github.com/subconsciousnetwork/subconscious/assets/5009316/78dd7d21-a739-4074-8c18-337f8049f259">


# TODO

- [x] Tests for TranscludeService
    - Insert some notes
    - Force indexing them
    - Call `.fetchTranscludes` with expected links
    - Try different owner values?
- [x] Use `.findAndPushDetail`
@bfollington bfollington mentioned this issue Jul 17, 2023
Merged
bfollington added a commit that referenced this issue Jul 20, 2023
@bfollington
Implement full transclusion design (#795)
1962cdb 
Fixes #799
Fixes #793
Fixes #328
Fixes #811

- Display user pfp with slashlink on transcludes and backlinks
- Retire stopgap Transclude2View
- Cache user profiles to speed up loading
- Replace standalone slashlinks with transcludes
- Show up to the first _two_ blocks in the excerpt

<img
src="https://github.com/subconsciousnetwork/subconscious/assets/5009316/b6805ec3-dbd6-47b5-9ccc-42b6e459a663"
alt="Simulator Screenshot - iPhone 14 Pro - 2023-07-17 at 11 12 51"
width="320"> <img
src="https://github.com/subconsciousnetwork/subconscious/assets/5009316/cafaf8d3-4660-4b40-b57c-01a5fe9065f6"
alt="Simulator Screenshot - iPhone 14 Pro - 2023-07-17 at 11 14 44"
width="320">

<img
src="https://github.com/subconsciousnetwork/subconscious/assets/5009316/8b3a985a-d675-46ca-8699-44b4988dcd10"
alt="Simulator Screenshot - iPhone 14 Pro - 2023-07-17 at 11 14 29"
width="320"> <img
src="https://user-images.githubusercontent.com/5009316/253837677-d81a905c-bb99-4712-a860-4f3d4bbde4ff.png"
alt="Simulator Screenshot - iPhone 14 Pro - 2023-07-17 at 11 14 17"
width="320">


https://github.com/subconsciousnetwork/subconscious/assets/5009316/71bf964d-7afd-406b-ba08-8b870cb89e64
@github-project-automation github-project-automation bot moved this from 🧑‍🌾 In Progress to 🌱 Done in Subconscious + Noosphere Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bfollington bfollington

Labels
Enhancement New feature or request User Story
Projects
Subconscious + Noosphere
Status: 🌱 Done
Milestone
No milestone
2 participants
@gordonbrander @bfollington