Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernify #59

Open
2 tasks
subins2000 opened this issue Jul 30, 2023 · 2 comments
Open
2 tasks

Modernify #59

subins2000 opened this issue Jul 30, 2023 · 2 comments

Comments

@subins2000
Copy link
Owner

Will be done in branch modernify

  • Use vite
  • Move to typescript
@RonaldZielaznicki
Copy link

RonaldZielaznicki commented Nov 30, 2023

Was looking p2pt over to use in one of my projects and thought I'd drop a question or two that might help while you are doing this re-write to modernify.

1. Why not extend bittorrent-tracker's client instead of re-implementing much of its logic?

It looks like p2pt is a custom client that is passed over to the trackers. But when you start looking at the client implementation that bittorrent-tracker has and p2pt's implementation, there is overlap.

To point a few out, _defaultAnnounceOpts, _announce/_fetchPeers, getTrackerStats/scrape, setIdentifier/constructor.

There's a few more overlaps here and there. Not trying to say rolling completely custom isn't the way to go since we don't need the other tracker types but was wondering about that.

@subins2000
Copy link
Owner Author

@RonaldZielaznicki I don't exactly remember the reasons but I think it was because of the difference between the usecases. I guess I didn't want to carry all the methods from bittorrent-tracker's client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants