Skip to content

Conversation

@braver
Copy link
Collaborator

@braver braver commented Dec 21, 2025

See #9264

@mburknoe let me know when you've added the message to your package and tagged the latest version. Note this also renames the package to align with our guidelines (syntax packages should simply have the name of the language).

@braver braver self-assigned this Dec 21, 2025
@braver braver added feedback provided The changes and package have been seen by a reviewer mergeable The channel changes are good but some action from the author is still needed takeover Package ownership is changing labels Dec 21, 2025
@github-actions
Copy link

Package Review

Channel Diff

Removed Cisco Syntax Highlighter, changed (none), added Cisco.

Review for Cisco 1.0.1

No failures

1 warnings:
- '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    File: CiscoSyntax BadWifi.sublime-syntax


For more details on the report messages (for example how to resolve them), go to:
https://github.com/packagecontrol/st_package_reviewer/wiki

Copy link

@mburknoe mburknoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK, if this is needed from me, but this does look correct now! Thank you

@braver
Copy link
Collaborator Author

braver commented Dec 30, 2025

Excellent!

@braver braver merged commit 2327caa into master Dec 30, 2025
3 checks passed
@braver braver deleted the braver-patch-cisco branch December 30, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feedback provided The changes and package have been seen by a reviewer mergeable The channel changes are good but some action from the author is still needed takeover Package ownership is changing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants