-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EPIC] White brand docs #707
Comments
|
Thanks for your feedback @berrydenhartog we'll prioritize at least the 3 first ones. |
Rename this as an EPIC, it will be better to tackle these in several issues. Can you guys help by opening the most prioritized one ? |
@berrydenhartog Currently it is not possible to change the frontend without changing the source and re-building the image. Maybe we can discuss/find a better way to customize and add custom modules. |
@rvveber i agree with you that it is indeed hard to dynamically set colors. I see a few solutions, all are not dynamicly loaded on runtime (except 4).
|
I propose this theme based on the official colors of Europe. |
Hey @rl-83 I really liked the yellow shadow on the Docs Logo can we have it back ? |
If I'm not mistaken, the proposed theme is still using Marianne as the font - @rl-83 do you confirm? if so, could we replace this with a font anyone can legally use? |
Hey @AntoLC
|
I do like the first option the most. We would not need to define a "Theme" via the Backend, because the css vars would already be Theme definition and could be overwritten at any point. @AntoLC And everything else could also be customized via E.g. instead of defining a boolean in json theme to "activate LaGaufre" which requires it to be hardcoded into the app - It would force us to re-design components with general purpose and sensible pre-defined defaults. I can't think of a better solution at the moment. |
I am indeed in favor of option 1 or 3. But i leave it to the implementer to make choice since they can best estimate what the impact would be on the codebase. I did not do a deep dive into the source yet. If they prefer a theme, that would be fine for now. It would however limit flexibility for others hosting Docs. I myself would go for option 1 because it gives allot of flexibility for everyone wanting to use Docs and does not require a compile step |
I really like the concept, which I think is great, but the code seems to hardcode the dinum which in turn calls this fixed list AFAICT "La Gaufre" would be easy to self-host if it's only a small piece of js and a static html list (would need some documentation though), or even could be optionally provided as a small pod of docs with an ingress to /gaufre and a configmap (or a volume) |
Feature Request
Is your feature request related to a problem or unsupported use case? Please describe.
As a reuser of Docs when I instanciate Docs many things are irrelevant to the context of my organization:
Describe the solution you'd like
As reuser of Docs I want to be able to instanciate Docs and be able to personalize it to my own context.
I should be able to do it in a simple and maintainable way (meaning I shouldn't struggle with version upgrades)
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Discovery, Documentation, Adoption, Migration Strategy
If you can, explain how users will be able to use this and possibly write out a version the docs (if applicable).
Maybe a screenshot or design?
Do you want to work on it through a Pull Request?
The text was updated successfully, but these errors were encountered: