Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer should remember settings #4291

Open
Suesskirsche opened this issue May 29, 2024 · 2 comments
Open

Installer should remember settings #4291

Suesskirsche opened this issue May 29, 2024 · 2 comments

Comments

@Suesskirsche
Copy link

I just upgraded from Sumatra 3.4.6 to 3.5.2 under Windows 10 and noticed following glitches:

  1. The installer does not read / remember my current Sumatra path settings (:*Tools.W64*\SumatraPDF) and
  2. after correcting the path manually overwrites it again with the default setting (:*Program Files*\SumatraPDF) when selecting "Install for all users" and
  3. forgets which documents were opened before installation. I frequently do have many pdf files open so it would be nice if these were remembered and I don't have to manually reopen them again.
@Suesskirsche Suesskirsche changed the title Installer should remember settings! Installer should remember settings May 29, 2024
@kjk
Copy link
Member

kjk commented May 29, 2024

When you say Sumatra path settings are you referring to custom installation directory?

Looking at the code, when installing for all users, we might ignore previous installation dir and reset to the default (GetDefaultInstallationDirTemp).

2 changes needed:

  • need to be smarter about this
  • when upgrading (detecting a previous install) we should auto-show the options, to make things clear
  • if changing install directory, copy settings file

@kjk
Copy link
Member

kjk commented May 29, 2024

@GitHubRulesOK I removed your comment because it wasn't addressing the issue and possibly adding confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants