Skip to content

Commit

Permalink
Move close button label translations inside the Dialog component (#2871)
Browse files Browse the repository at this point in the history 
* Move all close label translations inside the Dialog component

* Cleanup components' props interfaces

* add changelog entry for components refactoring
  • Loading branch information
@sirineJ
sirineJ authored Jan 16, 2025
1 parent 49ab488 commit 6c6e2ac
Show file tree
Hide file tree
Showing 136 changed files with 45 additions and 226 deletions.
5 changes: 5 additions & 0 deletions .changeset/spicy-avocados-provide.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@sumup-oss/circuit-ui": minor
---

Refactored the Modal, Popover, Toggletip, DateInput, SidePanel and SideNavigation components to leverage the internal Dialog component for improved consistency and maintainability.
1 change: 1 addition & 0 deletions packages/circuit-ui/components/DateInput/DateInput.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,7 @@ export const DateInput = forwardRef<HTMLInputElement, DateInputProps>(
animationDuration={isMobile ? animationDuration : 0}
aria-labelledby={headlineId}
style={dialogStyles}
locale={locale}
closeButtonLabel={closeCalendarButtonLabel}
>
{() => (
Expand Down
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/bg-BG.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Месец",
"dayInputLabel": "Ден",
"openCalendarButtonLabel": "Промяна на дата",
"closeCalendarButtonLabel": "Затваряне на календар",
"applyDateButtonLabel": "Прилагане на дата",
"clearDateButtonLabel": "Изчистване на дата"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/cs-CZ.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Měsíc",
"dayInputLabel": "Den",
"openCalendarButtonLabel": "Změnit datum",
"closeCalendarButtonLabel": "Zavřít kalendář",
"applyDateButtonLabel": "Použít datum",
"clearDateButtonLabel": "Vymazat datum"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/da-DK.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Måned",
"dayInputLabel": "Dag",
"openCalendarButtonLabel": "Skift dato",
"closeCalendarButtonLabel": "Luk kalender",
"applyDateButtonLabel": "Anvend dato",
"clearDateButtonLabel": "Slet dato"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/de-AT.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Monat",
"dayInputLabel": "Tag",
"openCalendarButtonLabel": "Datum ändern",
"closeCalendarButtonLabel": "Kalender schließen",
"applyDateButtonLabel": "Datum anwenden",
"clearDateButtonLabel": "Datum löschen"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/de-CH.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Monat",
"dayInputLabel": "Tag",
"openCalendarButtonLabel": "Datum ändern",
"closeCalendarButtonLabel": "Kalender schließen",
"applyDateButtonLabel": "Datum anwenden",
"clearDateButtonLabel": "Datum löschen"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/de-DE.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Monat",
"dayInputLabel": "Tag",
"openCalendarButtonLabel": "Datum ändern",
"closeCalendarButtonLabel": "Kalender schließen",
"applyDateButtonLabel": "Datum anwenden",
"clearDateButtonLabel": "Datum löschen"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/de-LU.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Monat",
"dayInputLabel": "Tag",
"openCalendarButtonLabel": "Datum ändern",
"closeCalendarButtonLabel": "Kalender schließen",
"applyDateButtonLabel": "Datum anwenden",
"clearDateButtonLabel": "Datum löschen"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/el-CY.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Μήνας",
"dayInputLabel": "Ημέρα",
"openCalendarButtonLabel": "Αλλαγή ημερομηνίας",
"closeCalendarButtonLabel": "Κλείσιμο ημερολογίου",
"applyDateButtonLabel": "Εφαρμογή ημερομηνίας",
"clearDateButtonLabel": "Εκκαθάριση ημερομηνίας"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/el-GR.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Μήνας",
"dayInputLabel": "Ημέρα",
"openCalendarButtonLabel": "Αλλαγή ημερομηνίας",
"closeCalendarButtonLabel": "Κλείσιμο ημερολογίου",
"applyDateButtonLabel": "Εφαρμογή ημερομηνίας",
"clearDateButtonLabel": "Εκκαθάριση ημερομηνίας"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/en-AU.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Month",
"dayInputLabel": "Day",
"openCalendarButtonLabel": "Change date",
"closeCalendarButtonLabel": "Close calendar",
"applyDateButtonLabel": "Apply date",
"clearDateButtonLabel": "Clear date"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/en-GB.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Month",
"dayInputLabel": "Day",
"openCalendarButtonLabel": "Change date",
"closeCalendarButtonLabel": "Close calendar",
"applyDateButtonLabel": "Apply date",
"clearDateButtonLabel": "Clear date"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/en-IE.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Month",
"dayInputLabel": "Day",
"openCalendarButtonLabel": "Change date",
"closeCalendarButtonLabel": "Close calendar",
"applyDateButtonLabel": "Apply date",
"clearDateButtonLabel": "Clear date"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/en-MT.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Month",
"dayInputLabel": "Day",
"openCalendarButtonLabel": "Change date",
"closeCalendarButtonLabel": "Close calendar",
"applyDateButtonLabel": "Apply date",
"clearDateButtonLabel": "Clear date"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/en-US.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Month",
"dayInputLabel": "Day",
"openCalendarButtonLabel": "Change date",
"closeCalendarButtonLabel": "Close calendar",
"applyDateButtonLabel": "Apply date",
"clearDateButtonLabel": "Clear date"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/es-CL.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Mes",
"dayInputLabel": "Día",
"openCalendarButtonLabel": "Cambiar la fecha",
"closeCalendarButtonLabel": "Cerrar calendario",
"applyDateButtonLabel": "Aplicar fecha",
"clearDateButtonLabel": "Borrar fecha"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/es-CO.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Mes",
"dayInputLabel": "Día",
"openCalendarButtonLabel": "Cambiar fecha",
"closeCalendarButtonLabel": "Cerrar calendario",
"applyDateButtonLabel": "Aplicar fecha",
"clearDateButtonLabel": "Borrar fecha"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/es-ES.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Mes",
"dayInputLabel": "Día",
"openCalendarButtonLabel": "Cambiar fecha",
"closeCalendarButtonLabel": "Cerrar calendario",
"applyDateButtonLabel": "Aplicar fecha",
"clearDateButtonLabel": "Borrar fecha"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/es-MX.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Mes",
"dayInputLabel": "Día",
"openCalendarButtonLabel": "Cambiar fecha",
"closeCalendarButtonLabel": "Cerrar calendario",
"applyDateButtonLabel": "Aplicar fecha",
"clearDateButtonLabel": "Borrar fecha"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/es-PE.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Mes",
"dayInputLabel": "Día",
"openCalendarButtonLabel": "Cambiar fecha",
"closeCalendarButtonLabel": "Cerrar calendario",
"applyDateButtonLabel": "Aplicar fecha",
"clearDateButtonLabel": "Borrar fecha"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/es-US.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Mes",
"dayInputLabel": "Día",
"openCalendarButtonLabel": "Cambiar fecha",
"closeCalendarButtonLabel": "Cerrar calendario",
"applyDateButtonLabel": "Aplicar fecha",
"clearDateButtonLabel": "Borrar fecha"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/et-EE.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Kuu",
"dayInputLabel": "Päev",
"openCalendarButtonLabel": "Kuupäeva muutmine",
"closeCalendarButtonLabel": "Sulge kalender",
"applyDateButtonLabel": "Rakenda kuupäev",
"clearDateButtonLabel": "Tühjenda kuupäev"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/fi-FI.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Kuukausi",
"dayInputLabel": "Päivä",
"openCalendarButtonLabel": "Vaihda päivämäärä",
"closeCalendarButtonLabel": "Sulje kalenteri",
"applyDateButtonLabel": "Käytä päivämäärää",
"clearDateButtonLabel": "Tyhjennä päivämäärä"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/fr-BE.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Mois",
"dayInputLabel": "Jour",
"openCalendarButtonLabel": "Modifier la date",
"closeCalendarButtonLabel": "Fermer le calendrier",
"applyDateButtonLabel": "Appliquer la date",
"clearDateButtonLabel": "Supprimer la date"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/fr-CH.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Mois",
"dayInputLabel": "Jour",
"openCalendarButtonLabel": "Modifier la date",
"closeCalendarButtonLabel": "Fermer le calendrier",
"applyDateButtonLabel": "Appliquer la date",
"clearDateButtonLabel": "Supprimer la date"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/fr-FR.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Mois",
"dayInputLabel": "Jour",
"openCalendarButtonLabel": "Modifier la date",
"closeCalendarButtonLabel": "Fermer le calendrier",
"applyDateButtonLabel": "Appliquer la date",
"clearDateButtonLabel": "Supprimer la date"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/fr-LU.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Mois",
"dayInputLabel": "Jour",
"openCalendarButtonLabel": "Modifier la date",
"closeCalendarButtonLabel": "Fermer le calendrier",
"applyDateButtonLabel": "Appliquer la date",
"clearDateButtonLabel": "Supprimer la date"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/hr-HR.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Mjesec",
"dayInputLabel": "Dan",
"openCalendarButtonLabel": "Promijeni datum",
"closeCalendarButtonLabel": "Zatvori kalendar",
"applyDateButtonLabel": "Primijeni datum",
"clearDateButtonLabel": "Izbriši datum"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/hu-HU.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Hónap",
"dayInputLabel": "Nap",
"openCalendarButtonLabel": "Dátum módosítása",
"closeCalendarButtonLabel": "Naptár bezárása",
"applyDateButtonLabel": "Dátuma alkalmazása",
"clearDateButtonLabel": "Dátum törlése"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/it-CH.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Mese",
"dayInputLabel": "Giorno",
"openCalendarButtonLabel": "Modifica data",
"closeCalendarButtonLabel": "Chiudi calendario",
"applyDateButtonLabel": "Applica data",
"clearDateButtonLabel": "Rimuovi data"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/it-IT.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Mese",
"dayInputLabel": "Giorno",
"openCalendarButtonLabel": "Modifica data",
"closeCalendarButtonLabel": "Chiudi calendario",
"applyDateButtonLabel": "Applica data",
"clearDateButtonLabel": "Rimuovi data"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/lt-LT.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Mėnuo",
"dayInputLabel": "Diena",
"openCalendarButtonLabel": "Keisti datą",
"closeCalendarButtonLabel": "Uždaryti kalendorių",
"applyDateButtonLabel": "Taikyti datą",
"clearDateButtonLabel": "Išvalyti datą"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/lv-LV.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Mēnesis",
"dayInputLabel": "Diena",
"openCalendarButtonLabel": "Mainīt datumu",
"closeCalendarButtonLabel": "Aizvērt kalendāru",
"applyDateButtonLabel": "Piemērot datumu",
"clearDateButtonLabel": "Notīrīt datumu"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/nb-NO.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Måned",
"dayInputLabel": "Dag",
"openCalendarButtonLabel": "Endre dato",
"closeCalendarButtonLabel": "Lukk kalender",
"applyDateButtonLabel": "Bruk dato",
"clearDateButtonLabel": "Slett dato"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/nl-BE.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Maand",
"dayInputLabel": "Dag",
"openCalendarButtonLabel": "Datum wijzigen",
"closeCalendarButtonLabel": "Agenda sluiten",
"applyDateButtonLabel": "Datum toepassen",
"clearDateButtonLabel": "Datum wissen"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/nl-NL.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Maand",
"dayInputLabel": "Dag",
"openCalendarButtonLabel": "Datum wijzigen",
"closeCalendarButtonLabel": "Agenda sluiten",
"applyDateButtonLabel": "Datum toepassen",
"clearDateButtonLabel": "Datum wissen"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/pl-PL.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Miesiąc",
"dayInputLabel": "Dzień",
"openCalendarButtonLabel": "Zmień datę",
"closeCalendarButtonLabel": "Zamknij kalendarz",
"applyDateButtonLabel": "Zastosuj datę",
"clearDateButtonLabel": "Usuń datę"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/pt-BR.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Mês",
"dayInputLabel": "Dia",
"openCalendarButtonLabel": "Alterar data",
"closeCalendarButtonLabel": "Fechar agenda",
"applyDateButtonLabel": "Aplicar data",
"clearDateButtonLabel": "Limpar data"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/pt-PT.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Mês",
"dayInputLabel": "Dia",
"openCalendarButtonLabel": "Alterar data",
"closeCalendarButtonLabel": "Fechar calendário",
"applyDateButtonLabel": "Aplicar data",
"clearDateButtonLabel": "Limpar data"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/ro-RO.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Lună",
"dayInputLabel": "Zi",
"openCalendarButtonLabel": "Modifică data",
"closeCalendarButtonLabel": "Închide calendarul",
"applyDateButtonLabel": "Aplică data",
"clearDateButtonLabel": "Șterge data"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/sk-SK.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Mesiac",
"dayInputLabel": "Deň",
"openCalendarButtonLabel": "Zmeniť dátum?",
"closeCalendarButtonLabel": "Zatvoriť kalendár",
"applyDateButtonLabel": "Vybrať dátum",
"clearDateButtonLabel": "Vymazať dátum"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/sl-SI.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Mesec",
"dayInputLabel": "Dan",
"openCalendarButtonLabel": "Spremeni datum",
"closeCalendarButtonLabel": "Zapri koledar",
"applyDateButtonLabel": "Uporabi datum",
"clearDateButtonLabel": "Počisti datum"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/DateInput/translations/sv-SE.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"monthInputLabel": "Månad",
"dayInputLabel": "Dag",
"openCalendarButtonLabel": "Ändra datum",
"closeCalendarButtonLabel": "Stäng kalendern",
"applyDateButtonLabel": "Välj datum",
"clearDateButtonLabel": "Rensa datum"
}
1 change: 0 additions & 1 deletion packages/circuit-ui/components/Dialog/Dialog.stories.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ const baseArgs: DialogProps = {
onCloseEnd: () => {},
'aria-labelledby': 'title',
'aria-describedby': 'description',
closeButtonLabel: 'Close',
children: defaultChildren,
style: dialogStyles,
};
Expand Down
6 changes: 4 additions & 2 deletions packages/circuit-ui/components/Dialog/Dialog.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,11 @@ import { clsx } from '../../styles/clsx.js';
import { useClickOutside } from '../../hooks/useClickOutside/index.js';
import { useEscapeKey } from '../../hooks/useEscapeKey/index.js';
import { useLatest } from '../../hooks/useLatest/index.js';
import { useI18n } from '../../hooks/useI18n/useI18n.js';

import { getFirstFocusableElement } from './DialogService.js';
import classes from './dialog.module.css';
import { translations } from './translations/index.js';

type DataAttribute = `data-${string}`;

Expand Down Expand Up @@ -86,7 +88,7 @@ export interface DialogProps
*/
preventClose?: boolean;
/**
* Enables focusing a particular element in the dialog content and override default behavior. This will have no effect if the dialog is not modal.
* Enables focusing a particular element in the dialog content and overrides the default behavior.
* @default `false`.
*/
initialFocusRef?: RefObject<HTMLElement>;
Expand Down Expand Up @@ -119,7 +121,7 @@ export const Dialog = forwardRef<HTMLDialogElement, DialogProps>(
animationDuration = 0,
onCloseStart,
...rest
} = props;
} = useI18n(props, translations);
const dialogRef = useRef<HTMLDialogElement>(null);
const openRef = useLatest<boolean>(open);
const animationDurationRef = useLatest<number>(animationDuration);
Expand Down
0 .../components/Modal/translations/bg-BG.json → ...components/Dialog/translations/bg-BG.json
View file
File renamed without changes.
0 .../components/Modal/translations/cs-CZ.json → ...components/Dialog/translations/cs-CZ.json
View file
File renamed without changes.
0 .../components/Modal/translations/da-DK.json → ...components/Dialog/translations/da-DK.json
View file
File renamed without changes.
0 .../components/Modal/translations/de-AT.json → ...components/Dialog/translations/de-AT.json
View file
File renamed without changes.
0 .../components/Modal/translations/de-CH.json → ...components/Dialog/translations/de-CH.json
View file
File renamed without changes.
0 .../components/Modal/translations/de-DE.json → ...components/Dialog/translations/de-DE.json
View file
File renamed without changes.
0 .../components/Modal/translations/de-LU.json → ...components/Dialog/translations/de-LU.json
View file
File renamed without changes.
0 .../components/Modal/translations/el-CY.json → ...components/Dialog/translations/el-CY.json
View file
File renamed without changes.
0 .../components/Modal/translations/el-GR.json → ...components/Dialog/translations/el-GR.json
View file
File renamed without changes.
0 .../components/Modal/translations/en-AU.json → ...components/Dialog/translations/en-AU.json
View file
File renamed without changes.
0 .../components/Modal/translations/en-GB.json → ...components/Dialog/translations/en-GB.json
View file
File renamed without changes.
0 .../components/Modal/translations/en-IE.json → ...components/Dialog/translations/en-IE.json
View file
File renamed without changes.
0 .../components/Modal/translations/en-MT.json → ...components/Dialog/translations/en-MT.json
View file
File renamed without changes.
0 .../components/Modal/translations/en-US.json → ...components/Dialog/translations/en-US.json
View file
File renamed without changes.
0 .../components/Modal/translations/es-CL.json → ...components/Dialog/translations/es-CL.json
View file
File renamed without changes.
0 .../components/Modal/translations/es-CO.json → ...components/Dialog/translations/es-CO.json
View file
File renamed without changes.
0 .../components/Modal/translations/es-ES.json → ...components/Dialog/translations/es-ES.json
View file
File renamed without changes.
0 .../components/Modal/translations/es-MX.json → ...components/Dialog/translations/es-MX.json
View file
File renamed without changes.
0 .../components/Modal/translations/es-PE.json → ...components/Dialog/translations/es-PE.json
View file
File renamed without changes.
0 .../components/Modal/translations/es-US.json → ...components/Dialog/translations/es-US.json
View file
File renamed without changes.
0 .../components/Modal/translations/et-EE.json → ...components/Dialog/translations/et-EE.json
View file
File renamed without changes.
0 .../components/Modal/translations/fi-FI.json → ...components/Dialog/translations/fi-FI.json
View file
File renamed without changes.
0 .../components/Modal/translations/fr-BE.json → ...components/Dialog/translations/fr-BE.json
View file
File renamed without changes.
0 .../components/Modal/translations/fr-CH.json → ...components/Dialog/translations/fr-CH.json
View file
File renamed without changes.
0 .../components/Modal/translations/fr-FR.json → ...components/Dialog/translations/fr-FR.json
View file
File renamed without changes.
0 .../components/Modal/translations/fr-LU.json → ...components/Dialog/translations/fr-LU.json
View file
File renamed without changes.
0 .../components/Modal/translations/hr-HR.json → ...components/Dialog/translations/hr-HR.json
View file
File renamed without changes.
0 .../components/Modal/translations/hu-HU.json → ...components/Dialog/translations/hu-HU.json
View file
File renamed without changes.
0 ...ui/components/Modal/translations/index.ts → ...i/components/Dialog/translations/index.ts
View file
File renamed without changes.
0 .../components/Modal/translations/it-CH.json → ...components/Dialog/translations/it-CH.json
View file
File renamed without changes.
0 .../components/Modal/translations/it-IT.json → ...components/Dialog/translations/it-IT.json
View file
File renamed without changes.
0 .../components/Modal/translations/lt-LT.json → ...components/Dialog/translations/lt-LT.json
View file
File renamed without changes.
0 .../components/Modal/translations/lv-LV.json → ...components/Dialog/translations/lv-LV.json
View file
File renamed without changes.
0 .../components/Modal/translations/nb-NO.json → ...components/Dialog/translations/nb-NO.json
View file
File renamed without changes.
0 .../components/Modal/translations/nl-BE.json → ...components/Dialog/translations/nl-BE.json
View file
File renamed without changes.
0 .../components/Modal/translations/nl-NL.json → ...components/Dialog/translations/nl-NL.json
View file
File renamed without changes.
0 .../components/Modal/translations/pl-PL.json → ...components/Dialog/translations/pl-PL.json
View file
File renamed without changes.
0 .../components/Modal/translations/pt-BR.json → ...components/Dialog/translations/pt-BR.json
View file
File renamed without changes.
0 .../components/Modal/translations/pt-PT.json → ...components/Dialog/translations/pt-PT.json
View file
File renamed without changes.
0 .../components/Modal/translations/ro-RO.json → ...components/Dialog/translations/ro-RO.json
View file
File renamed without changes.
0 .../components/Modal/translations/sk-SK.json → ...components/Dialog/translations/sk-SK.json
View file
File renamed without changes.
0 .../components/Modal/translations/sl-SI.json → ...components/Dialog/translations/sl-SI.json
View file
File renamed without changes.
0 .../components/Modal/translations/sv-SE.json → ...components/Dialog/translations/sv-SE.json
View file
File renamed without changes.
3 changes: 0 additions & 3 deletions packages/circuit-ui/components/Modal/Modal.stories.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,7 @@ const openModal = async ({
const baseArgs: ModalProps = {
open: false,
onClose: () => {},
'aria-labelledby': 'title',
'aria-describedby': 'description',
variant: 'contextual',
closeButtonLabel: 'Close',
children: defaultModalChildren,
};

Expand Down
Loading

0 comments on commit 6c6e2ac

Please sign in to comment.