Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limit should not depend on a created_at column being present #29

Open
brki opened this issue Jan 15, 2016 · 0 comments
Open

limit should not depend on a created_at column being present #29

brki opened this issue Jan 15, 2016 · 0 comments

Comments

@brki
Copy link

brki commented Jan 15, 2016

It should be possible to use the limit option without a created_at column being present.

data-anonymization/lib/strategy/base.rb

Line 135 in 6668330

source_table.all.limit(@limit).order(created_at: :desc)

Perhaps allow specifying a order_by option, and if that is not present, do no ordering.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brki