You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In sunpy.instr.fermi, both get_detector_sun_angles_for_time() and get_detector_sun_angles_for_date() call sunpy.sun.sun functions to get the Sun's right ascension and declination. They use the functions for the apparent RA/dec referenced to the equinox of date, but I suspect that Fermi reports the spacecraft RA/dec (and hence the detectors' RA/dec) as astrometric RA/dec referenced to the J2000.0 epoch. (With sunpy/sunpy#3137, we can now provide precisely that RA/dec.) The coordinate frame used by Fermi needs to be confirmed, and the RA/dec calls changed if necessary.
Great! You also need to confirm whether the RA/dec are astrometric or apparent. That is, whether spacecraft motion is taken out (astrometric) or not (apparent).
In
sunpy.instr.fermi
, bothget_detector_sun_angles_for_time()
andget_detector_sun_angles_for_date()
callsunpy.sun.sun
functions to get the Sun's right ascension and declination. They use the functions for the apparent RA/dec referenced to the equinox of date, but I suspect that Fermi reports the spacecraft RA/dec (and hence the detectors' RA/dec) as astrometric RA/dec referenced to the J2000.0 epoch. (With sunpy/sunpy#3137, we can now provide precisely that RA/dec.) The coordinate frame used by Fermi needs to be confirmed, and the RA/dec calls changed if necessary.Ping @aringlis
The text was updated successfully, but these errors were encountered: