fix: Update supa_socials_auth.dart to include slackOidc and linkedInOidc OAuthProvider value mappings #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshukertjr
reviewed
Oct 20, 2024
Comment on lines
+61
to
+67
| String get capitalizedName { | ||
| String modifiedName = name; | ||
| if (name.endsWith("Oidc")) { | ||
| modifiedName = name.substring(0, name.length - 4); | ||
| } | ||
| return modifiedName[0].toUpperCase() + modifiedName.substring(1); | ||
| } |
There was a problem hiding this comment.
Let's keep the same labelText getter name, but modify the definition in a way that the Oidc is removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix
What is the current behavior?
Passing
OAuthProvider.linkedinOidcorOAuthProvider.slackOidcprovides no icon and no color styling.What is the new behavior?
Provides the same existing styling & icon for
linkedinOidcandslackOidcas their non-oidc counterparts.Additional context
Related to other PR in supabase-flutter to add slackOidc provider option: supabase/supabase-flutter#1066