-
Notifications
You must be signed in to change notification settings - Fork 98
install lsp on debian (glibc issue) #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Can you try building it from source? we will check why the build does not work properly. |
@elasticspoon what |
@elasticspoon When I run Is upgrading the glibc an option? |
Unfortunately, upgrading glibc is only very rarely an option - saying this is almost always is asking the user to either upgrade to a different version of their OS or risk breaking their OS. In the circumstance above, glibc 2.36 (2022-08-01) is only one version behind the max released version when debian bookworm was released (2023-06-10) and, if I understand correctly, it's very rare that distros upgrade glibc on the same major OS version. Personally, I'm stuck with 2.34 (2021-08-02) for the next 5+? years because we use Rocky 9 (initial release 2022-07-14, full EOL 2032-05-31). I appreciate that 2.39 (2024-01-31) is more than a year old but, imo, many people use LTS releases and it would be extraordinarily helpful to offer binaries for older glibc |
I am in the same position. I was not able to use the complied release binaries and had to build them myself to get them working. I'm sure many people are in the same position. Some perspective users might not have the time/knowledge to compile binaries that work on their system and just move on to other things instead. Highly recommend targeting a glibc version that works for systems that are older but not yet EOL. |
Thank you for the feedback. I'll check out whether we can adjust the compile targets such that we use an older version 👍 |
Just to confirm what others are saying, yea its an older glibc that probably won't get upgraded until debian upgrades (not sure how that bit works).
I would love if you could update the compile targets because I how no clue how I would build a binary to use the older glibc. FWIW these are the glibc versions being used on debian: https://tracker.debian.org/pkg/glibc |
Could you give me a run down of how I would do that? Or a link? Totally unfamiliar with rust and don't see anything like a Makefile. |
@juleswritescode thanks! appreciate you looking into this change |
The README used to have build instructions but they were removed with commit 46b679a. Would be very helpful if build instructions were added to the README or at least a link to a separate document that has build instructions. |
just fyi: we have an issue with a dependency that prevents gnu builds in general at the moment. fixing this upstream now, and will do a new release + add the build from source instructions afterwards. |
for what its worth: upstream issues are resolved :) |
I have not had time to try to build this from source but #318 reads like next release might fix this? |
@elasticspoon I think so! The Ubuntu-22.04 runner uses glibc version 2.35, so the binary should work with 2.36. I also tried the Ubuntu-20.04 runner, which uses glibc 2.31, but then we would get more issues with upstream dependencies. Hopefully, 2.35 will already help many people. We'll also add instructions to build from source again. 👍 |
Waiting for that fix. |
Version 0.4.0 includes the fix and is released. Can you try again? :) |
$ > postgrestools check test.sql
Checked 1 file in 5ms. No fixes applied. Eyyyy. It works! Thanks a bunch @juleswritescode! Feel free to close the issue. |
Bug report
Describe the bug
I am trying to install postgrestools on debian bookworm and I have tried both the npm installation method and the binary installation method and neither work. Any suggestions?
Via binary:
Via NPM:
System information
The text was updated successfully, but these errors were encountered: