add test for parsing BEGIN, ROLLBACK, COMMIT statements #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @pert5432, thanks for the contribution! Sorry it took so long. We finally finished the parser implementation. Would you mind re-trying the pr? we dropped the snapshot tests, so if you could remove the snapshot and re-try the test that would be great. Thanks a lot. Also, check out #51 if you have continued interest to contribute. |
|
Yo, I'll re-do it, no problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Added test
What is the current behavior?
Transaction statement parsing was not tested
What is the new behavior?
Transaction statement parsing is now tested
closes #36