Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Check if url is an HTTP URL #12

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

feat: Check if url is an HTTP URL #12

wants to merge 14 commits into from

Conversation

juancarlospaco
Copy link
Collaborator

What kind of change does this PR introduce?

  • Check if url arg is an HTTP URL.

@juancarlospaco juancarlospaco marked this pull request as ready for review November 4, 2024 16:12
olirice
olirice reviewed Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@olirice olirice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you pls add a test case to exercise this failure mode?

other than that, looks good to me!

@juancarlospaco juancarlospaco marked this pull request as draft November 11, 2024 20:16
@olirice
Copy link
Collaborator

olirice commented Nov 12, 2024

For the test I think you'll want

with pytest.raises(...):

https://docs.pytest.org/en/7.1.x/reference/reference.html#pytest.raises

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olirice olirice olirice left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juancarlospaco @olirice