Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Replace inbucket with mailpit. For now I'm opening this to start a discussion about this change as I believe mailpit provides more verbose features and works quite well after testing it for a week now. I've kept this PR at a minimal in order to keep backward compatibility and not have a breaking change. I did at first changed all references to
inbucket
to bemailpit
but realised this would cause a break in everyone'sconfig.toml
since they would still be referencing[inbucket]
. What could be done instead is to create a new config for mailpit but this time it should be given a universal name rather than the service we are using name. So instead of[inbucket]
or[mailpit]
it should be more generic like[mail]
this way if this is to change in the future it would all be internal changes and none breaking to it's external use.The benefits I see in mailpit is that it has features like HTML check and an API for e2e testing too. The UI looked more refined and having the various views like HTML, HTML Source, Text, Headers, Raw amongst others was also good.
To test this you would have to set the registry to
docker.io
as Supabase doesn't have a mirror image of mailpit.Note
supalocal
is just an alias in my terminal to the built executable of thecli
.What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.