Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: output standard env vars from branches get #3221

Merged
merged 6 commits into from
Feb 27, 2025
Merged

feat: output standard env vars from branches get #3221

merged 6 commits into from
Feb 27, 2025
+237 −157

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Feb 27, 2025 •
edited
Loading

What kind of change does this PR introduce?

feature

What is the new behavior?

$ supabase --experimental branches get --output json
Selected branch ID: 709a7cc3-2cfd-417d-8828-76c8bbc58a1e
{
  "POSTGRES_URL": "postgresql://[email protected]:6543/postgres?connect_timeout=10",
  "POSTGRES_URL_NON_POOLING": "postgresql://[email protected]:5432/?connect_timeout=10",
  "SUPABASE_ANON_KEY": "...",
  "SUPABASE_SERVICE_ROLE_KEY": "...",
  "SUPABASE_URL": "https://kpojrjxbvujjhamjpcux.supabase.co"
}

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner February 27, 2025 09:51
@sweatybridge sweatybridge changed the title fix: output standard env vars from branches get feat: output standard env vars from branches get Feb 27, 2025
jgoux
jgoux approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@jgoux jgoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a tiny comment on the env variable names. 👍

pkg/function/batch.go
for slug, function := range functionConfig {
if !function.Enabled {
fmt.Fprintln(os.Stderr, "Skipped deploying Function:", slug)
continue
}
for _, keep := range filter {
if !keep(slug) {
continue
continue OUTER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Labeled statement, I don't see that everyday, nice. 😄

@sweatybridge sweatybridge merged commit 32064ab into develop Feb 27, 2025
10 checks passed
@sweatybridge sweatybridge deleted the branch-details branch February 27, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgoux jgoux jgoux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sweatybridge @jgoux