DO NOT MERGE UNTIL TESTING COMPLETE chore: move orioledb to extensions schema #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samrose
changed the title
samrose
force-pushed
the
sam/oriole-extensions-schema
branch
from
c9eecc4 to
cd6234a
Compare
darora
approved these changes
Feb 27, 2025
|
@darora thanks for the approval, I should have noted that we are going to hold off on merging this until I test restore, unpause. That should be done by end of day tomorrow, and then will set an actual vars.yml release version, and pr for rollout. Oliver stated that this does not require rollout to existing instances. But our policy now is to always test pause/unpause and restore, so will be doing that for sure. |
samrose
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Moves the orioledb extension to the extensions schema if:
orioledb is enabled in the public schema
the extensions schema exists
This is important because orioledb exposes some entities that we don't necessarily want exposed over APIs by default
Recommending we use this PR instead of #1433 as it is more up to date CI, less hassle toward reconciling git changes