Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle suspend properly; handle timeout rpc error #1311

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

filipecabaco
Copy link
Member

What kind of change does this PR introduce?

handle suspend properly; handle timeout rpc error

Copy link

vercel bot commented Feb 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
realtime-demo ⬜️ Ignored (Inspect) Visit Preview Feb 24, 2025 3:54pm

@filipecabaco filipecabaco force-pushed the fix/delete-endpoint-reduce-impact branch from db25d11 to 709d6ac Compare February 24, 2025 13:40
Copy link
Contributor

@chasers chasers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but why is every socket getting suspend messages for every tenant?

Shouldn't that be targeted when we send it?

@filipecabaco
Copy link
Member Author

It was (the message itself has it) but on the Connect module we were not using that information to actually kill the Connect module.

@coveralls
Copy link

coveralls commented Feb 24, 2025

Coverage Status

coverage: 81.914% (+0.9%) from 81.039%
when pulling f73106e on fix/delete-endpoint-reduce-impact
into 51b2b0a on main.

@filipecabaco filipecabaco force-pushed the fix/delete-endpoint-reduce-impact branch from 766bda3 to cf6ddcc Compare February 24, 2025 15:46
@filipecabaco filipecabaco force-pushed the fix/delete-endpoint-reduce-impact branch from cf6ddcc to f73106e Compare February 24, 2025 15:54
@filipecabaco filipecabaco merged commit 80e5475 into main Feb 24, 2025
4 of 6 checks passed
@filipecabaco filipecabaco deleted the fix/delete-endpoint-reduce-impact branch February 24, 2025 17:06
@kiwicopple
Copy link
Member

🎉 This PR is included in version 2.34.32 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants