-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Connect to tenant database on channel join #677
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
filipecabaco
force-pushed
the
feat/connect-tenant-on-join
branch
14 times, most recently
from
September 22, 2023 09:45
c831d32
to
ce7de8c
Compare
filipecabaco
force-pushed
the
feat/connect-tenant-on-join
branch
3 times, most recently
from
September 22, 2023 16:53
290a2db
to
d2a910d
Compare
chasers
reviewed
Sep 22, 2023
abc3
reviewed
Sep 25, 2023
abc3
reviewed
Sep 25, 2023
abc3
reviewed
Sep 25, 2023
filipecabaco
force-pushed
the
feat/connect-tenant-on-join
branch
3 times, most recently
from
October 5, 2023 01:03
ffaaaf0
to
d8a1636
Compare
abc3
reviewed
Oct 5, 2023
chasers
reviewed
Oct 5, 2023
filipecabaco
force-pushed
the
feat/connect-tenant-on-join
branch
from
October 10, 2023 00:19
bf650bc
to
11e4a79
Compare
abc3
reviewed
Oct 10, 2023
abc3
reviewed
Oct 10, 2023
abc3
reviewed
Oct 10, 2023
abc3
reviewed
Oct 10, 2023
abc3
reviewed
Oct 10, 2023
abc3
reviewed
Oct 10, 2023
abc3
reviewed
Oct 10, 2023
* GenServer only starts if able to connect to tenant database * Process using :syn process registry with the connection as metadata * DynamicSupervisor used to start GenServer * DynamicSupervisor provided by a PartitionSupervisor
filipecabaco
force-pushed
the
feat/connect-tenant-on-join
branch
from
October 11, 2023 21:28
0f35569
to
e1dc4d0
Compare
josevalim
reviewed
Oct 12, 2023
josevalim
reviewed
Oct 12, 2023
josevalim
reviewed
Oct 12, 2023
josevalim
reviewed
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Some comments added. :)
* Add tests to Realtime.Nodes
chasers
approved these changes
Oct 12, 2023
🎉 This PR is included in version 2.25.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Before Realtime Channel join it checks if we're able to connect to Tenant database. If not we exit and avoid the client from connecting with the Channel.
Current procedure:
SELECT 1
queryNotes:
SynHandler
made more reusable by allowing multiple modulesRealtime.Nodes
made with common functions required for node managementRealtime.Helpers
with extra functions for future refactorsFuture Work
Later we will want to evolve this feature to a more solid health check of the tenant database connection.