test(functions): background deno run in relay and clean up networks (#2739)

Signed-off-by: Ferhat Elmas <elmas.ferhat@gmail.com>

Author: ferhatelmas

packages/core/functions-js/test/relay/container.ts

@@ -1,44 +1,30 @@
 import * as fs from 'fs'
 import { nanoid } from 'nanoid'
 import { sign } from 'jsonwebtoken'
-import { GenericContainer, Network, StartedTestContainer, Wait } from 'testcontainers'
-import { ExecResult } from 'testcontainers/dist/docker/types'
+import {
+  GenericContainer,
+  Network,
+  StartedNetwork,
+  StartedTestContainer,
+  Wait,
+} from 'testcontainers'
 import { attach, log } from '../utils/jest-custom-reporter'
 
-/**
- * A Relay contains a running relay container that has a unique ID and two promises:
- * one for the `deno cache` and one for the `deno run` the required function
- */
 export class Relay {
   container: StartedTestContainer
+  network: StartedNetwork
   id: string
-  execCache: Promise<ExecResult>
-  execRun: Promise<ExecResult>
-  constructor(
-    container: StartedTestContainer,
-    id: string,
-    execCache: Promise<ExecResult>,
-    execRun: Promise<ExecResult>
-  ) {
+  constructor(container: StartedTestContainer, network: StartedNetwork, id: string) {
     this.container = container
+    this.network = network
     this.id = id
-    this.execCache = execCache
-    this.execRun = execRun
   }
 
-  /**
-   * Safely stops the relay container and cleans up exec processes
-   */
   async stop(): Promise<void> {
     try {
-      // Try to stop the container - this will trigger cleanup of exec instances
       await this.container.stop({ timeout: 5000 })
-    } catch (error: any) {
-      // Ignore "no such exec" errors during cleanup - they're harmless
-      if (!error?.message?.includes('no such exec')) {
-        throw error
-      }
-      // Container is already stopped or exec instances are gone, which is fine
+    } finally {
+      await this.network.stop()
     }
   }
 }
@@ -86,56 +72,64 @@ export async function runRelay(
 
   // start relay and function
   log(`start relay ${slug + '-' + id}`)
-  const startedRelay = await relay.start()
-  const execCache = startedRelay.exec(['deno', 'cache', `/home/deno/${slug}/index.ts`])
-  const execRun = startedRelay.exec([
-    'deno',
-    'run',
-    '--allow-all',
-    '--watch',
-    '--unstable',
-    `/home/deno/${slug}/index.ts`,
-  ])
+  const startedRelay = await relay.start().catch(async (error) => {
+    await network.stop().catch((stopError) => log(`failed to stop network ${id}: ${stopError}`))
+    throw error
+  })
+  const started = new Relay(startedRelay, network, id)
+  const functionPath = `/home/deno/${slug}/index.ts`
+  try {
+    for (const command of [
+      ['deno', 'cache', functionPath],
+      [
+        'sh',
+        '-c',
+        'deno run --allow-all --watch --unstable "$1" > /tmp/function.log 2>&1 < /dev/null &',
+        'sh',
+        functionPath,
+      ],
+    ]) {
+      const { exitCode, output } = await startedRelay.exec(command)
+      if (exitCode !== 0) {
+        throw new Error(`Failed to start function ${slug}: ${output}`)
+      }
+    }
 
-  // wait till function is running
-  log(`check function is healthy: ${slug + '-' + id}`)
-  for (let ctr = 0; ctr < 60; ctr++) {
-    try {
-      const healthCheck = await fetch(
-        `http://localhost:${startedRelay.getMappedPort(8081)}/${slug}`,
-        {
-          method: 'POST',
-          headers: {
-            Authorization: `Bearer ${sign({ name: 'check' }, jwtSecret)}`,
-          },
+    // wait till function is running
+    log(`check function is healthy: ${slug + '-' + id}`)
+    for (let ctr = 0; ctr < 60; ctr++) {
+      try {
+        const healthCheck = await fetch(
+          `http://localhost:${startedRelay.getMappedPort(8081)}/${slug}`,
+          {
+            method: 'POST',
+            headers: {
+              Authorization: `Bearer ${sign({ name: 'check' }, jwtSecret)}`,
+            },
+          }
+        )
+        if (healthCheck.ok) {
+          log(`function started to serve: ${slug + '-' + id}`)
+          // Add a small delay after health check passes to ensure full readiness
+          await new Promise((resolve) => setTimeout(resolve, 1000))
+          return started
         }
-      )
-      if (healthCheck.ok || healthCheck.status === 101) {
-        log(`function started to serve: ${slug + '-' + id}`)
-        // Add a small delay after health check passes to ensure full readiness
-        await new Promise((resolve) => setTimeout(resolve, 1000))
-        return new Relay(startedRelay, id, execCache, execRun)
-      }
-    } catch (error) {
-      // Native fetch throws an error when it encounters HTTP 101 (WebSocket upgrade)
-      // If we get a TypeError (which fetch throws for protocol errors like 101),
-      // we consider the function ready to serve
-      if (error instanceof TypeError) {
-        // This likely means we got a 101 response that native fetch couldn't handle
-        // The server is responding, so consider it ready
-        log(`function started to serve (detected via error): ${slug + '-' + id}`)
-        await new Promise((resolve) => setTimeout(resolve, 1000))
-        return new Relay(startedRelay, id, execCache, execRun)
+      } catch {
+        // relay not reachable yet (connection refused/reset), retry
       }
-      // For other errors (connection refused, etc.), continue retrying
+      await new Promise((resolve) => setTimeout(resolve, 500))
     }
-    await new Promise((resolve) => setTimeout(resolve, 500))
-  }
 
-  // if function hasn't started, stop container and throw
-  log(`function failed to start: ${slug + '-' + id}`)
-  startedRelay.stop()
-  throw new Error("function haven'start correctly")
+    // if function hasn't started, throw with its log
+    log(`function failed to start: ${slug + '-' + id}`)
+    const { output } = await startedRelay.exec(['cat', '/tmp/function.log'])
+    throw new Error(`function hasn't started correctly: ${output}`)
+  } catch (error) {
+    await started
+      .stop()
+      .catch((stopError) => log(`failed to stop relay ${slug + '-' + id}: ${stopError}`))
+    throw error
+  }
 }
 
 /**

pnpm-lock.yaml

@@ -34,6 +34,7 @@ overrides:
   # (GHSA-r28c-9q8g-f849, fixed in 8.5.18); next pins the old 8.4.31
   # transitively in the realtime example.
   postcss: '>=8.5.18'
+  source-map-js: '>=1.2.2'
   # Avoid the sourceMappingURL file-read advisory (GHSA-4x5r-pxfx-6jf8) in
   # @babel/core <=7.29.0; reached via next>styled-jsx in the realtime example.
   # (No 7.29.1 was ever published; 7.29.7 is the first fixed 7.x release.)
@@ -52,6 +53,7 @@ minimumReleaseAge: 10080 # 7 days
 minimumReleaseAgeExclude:
   - '@supabase/*'
   - supabase # first-party Supabase CLI
+  - source-map-js@1.2.2
 blockExoticSubdeps: true
 
 # Whitelist of packages allowed to run install scripts (preinstall/install/postinstall).