fix remove use_trs field

Author: minhpham212

server/stt/io/feeding_services/stt_tt_content_api.py

@@ -74,17 +74,6 @@ def _headers(self, api_key: str) -> Dict[str, str]:
                 "paginating. Range: 1-10000."
             ),
         },
-        {
-            "id": "use_trs",
-            "type": "boolean",
-            "label": "Use incremental sync (trs)",
-            "required": True,
-            "default": True,
-            "description": (
-                "When enabled, add the 'trs' query param with the last-updated timestamp "
-                "to fetch only items changed since the previous run."
-            ),
-        },
         {
             "id": "since_minutes",
             "type": "text",
@@ -166,7 +155,6 @@ def _fetch_tt_data(self, provider, update) -> List[Dict]:
           - page_size: int (default 50)
           - max_pages: int safety cap (default 200)
           - timeout: int per-request timeout (default 60)
-          - use_trs: bool (default True, 'trs' is RFC3339 timestamp in UTC)
           - since_minutes: int fallback lookback (default 1440)
         """
         url, api_key = self._get_config(provider)
@@ -178,36 +166,26 @@ def _fetch_tt_data(self, provider, update) -> List[Dict]:
         # safety cap to avoid runaway loops
         timeout = int(config.get("timeout", 60))
 
-        use_trs_config = config.get("use_trs", True)
-        if isinstance(use_trs_config, str):
-            use_trs = use_trs_config.strip().lower() in {"true", "1", "yes", "on"}
-        else:
-            use_trs = bool(use_trs_config)
         trs_value: str | None = None
-        if use_trs:
-            # Prefer last_updated from the update context, fallback to provider storage or lookback window
-            last_updated_str = None
-            if isinstance(update, dict):
-                last_updated_str = update.get("last_updated") or update.get(
-                    "last_update"
-                )
-            # Parse if available
-            dt_from: datetime | None = None
-            if isinstance(last_updated_str, str):
-                try:
-                    # Accept ISO-8601 with/without Z
-                    dt_from = datetime.fromisoformat(
-                        last_updated_str.replace("Z", "+00:00")
-                    )
-                except Exception:
-                    dt_from = None
-            if dt_from is None:
-                # Fallback: now - since_minutes
-                minutes = int(config.get("since_minutes", 1440))
-                dt_from = datetime.now(timezone.utc) - timedelta(minutes=minutes)
-            # TT expects 'trs' as an RFC3339 timestamp in UTC with seconds precision
-            dt_from = dt_from.astimezone(timezone.utc).replace(microsecond=0)
-            trs_value = dt_from.strftime("%Y-%m-%dT%H:%M:%SZ")
+        # Prefer last_updated from the update context, fallback to provider storage or lookback window
+        last_updated_str = None
+        if isinstance(update, dict):
+            last_updated_str = update.get("last_updated") or update.get("last_update")
+        # Parse if available
+        dt_from: datetime | None = None
+        if isinstance(last_updated_str, str):
+            try:
+                # Accept ISO-8601 with/without Z
+                dt_from = datetime.fromisoformat(last_updated_str.replace("Z", "+00:00"))
+            except Exception:
+                dt_from = None
+        if dt_from is None:
+            # Fallback: now - since_minutes
+            minutes = int(config.get("since_minutes", 1440))
+            dt_from = datetime.now(timezone.utc) - timedelta(minutes=minutes)
+        # TT expects 'trs' as an RFC3339 timestamp in UTC with seconds precision
+        dt_from = dt_from.astimezone(timezone.utc).replace(microsecond=0)
+        trs_value = dt_from.strftime("%Y-%m-%dT%H:%M:%SZ")
 
         # Prepare base URL components and preserve existing query params
         parsed = urlparse(url)

server/tests/stt_tt_content_api_test.py

@@ -377,8 +377,8 @@ def test_fetch_data_different_response_formats(self, mock_get):
         self.assertEqual(test_items[0]["uri"], items[0]["uri"])
 
     @patch.object(STTTTContentAPIService, "_get_with_retry")
-    def test_fetch_data_uses_trs_with_last_updated(self, mock_get):
-        """When use_trs is enabled and update contains last_updated, include trs in query."""
+    def test_fetch_data_adds_trs_with_last_updated(self, mock_get):
+        """When update contains last_updated, include trs in query."""
         # minimal 1-page flow
         mock_get.side_effect = [
             MockResponse({"hits": [TEST_TT_ITEMS[0]]}),
@@ -389,7 +389,6 @@ def test_fetch_data_uses_trs_with_last_updated(self, mock_get):
             "config": {
                 "url": "https://api.example.com/contentapi/items",
                 "api_key": "MY_TOKEN",
-                "use_trs": True,
             }
         }
         update = {"last_updated": "2025-09-24T10:00:00Z"}
@@ -403,7 +402,7 @@ def test_fetch_data_uses_trs_with_last_updated(self, mock_get):
 
     @patch.object(STTTTContentAPIService, "_get_with_retry")
     def test_fetch_data_uses_trs_fallback_since_minutes(self, mock_get):
-        """When use_trs enabled but no last_updated, use now - since_minutes as trs."""
+        """When no last_updated, use now - since_minutes as trs."""
         # one page then empty
         mock_get.side_effect = [
             MockResponse({"hits": [TEST_TT_ITEMS[0]]}),
@@ -414,7 +413,6 @@ def test_fetch_data_uses_trs_fallback_since_minutes(self, mock_get):
             "config": {
                 "url": "https://api.example.com/contentapi/items",
                 "api_key": "MY_TOKEN",
-                "use_trs": True,
                 "since_minutes": "120",
             }
         }
@@ -455,27 +453,8 @@ def test_timeout_configurable(self, mock_get):
         self.assertEqual(15, call_args[1]["timeout"])
 
     @patch.object(STTTTContentAPIService, "_get_with_retry")
-    def test_use_trs_boolean_coercion_from_text(self, mock_get):
-        """use_trs text values like 'true' should be treated as boolean True."""
-        mock_get.side_effect = [MockResponse({"hits": []})]
-        provider = {
-            "config": {
-                "url": "https://api.example.com/contentapi/items",
-                "api_key": "MY_TOKEN",
-                "use_trs": "true",
-            }
-        }
-        update = {"last_updated": "2025-09-24T10:00:00Z"}
-
-        _ = self.service._fetch_tt_data(provider, update)
-
-        call_args = mock_get.call_args
-        url = call_args[0][0]
-        self.assertIn("trs=2025-09-24T10%3A00%3A00Z", url)
-
-    @patch.object(STTTTContentAPIService, "_get_with_retry")
-    def test_use_trs_disabled_no_param(self, mock_get):
-        """When use_trs is disabled, the trs param should not be present."""
+    def test_trs_enforced_even_when_legacy_config_disables(self, mock_get):
+        """Legacy configs with use_trs=False should still yield trs in query."""
         mock_get.side_effect = [MockResponse({"hits": []})]
         provider = {
             "config": {
@@ -490,7 +469,7 @@ def test_use_trs_disabled_no_param(self, mock_get):
 
         call_args = mock_get.call_args
         url = call_args[0][0]
-        self.assertNotIn("trs=", url)
+        self.assertIn("trs=2025-09-24T10%3A00%3A00Z", url)
 
     @patch.object(STTTTContentAPIService, "_get_with_retry")
     def test_fetch_data_list_response(self, mock_get):