Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SuperEditor] [iOS] Vertical scrolling occurring during horizontal drag gestures #2081

Open
jakeett opened this issue Jun 10, 2024 · 2 comments
Assignees
Labels
area_super_reader Related to SuperReader area_supereditor Pertains to SuperEditor bounty_junior f:clickup platform_android Applies to use on Android platform_ios Applies to use on iOS time:2 type_bug Something isn't working

Comments

@jakeett
Copy link

jakeett commented Jun 10, 2024

Package Version
stable branch

In iOS apps, views containing a Super Editor can be scrolled vertically even when dragging horizontally. Once a horizontal drag gesture is initiated, only movement along the x-axis is consumed, and y-axis movements are ignored until a new drag gesture is started.

Screen.Recording.2024-06-10.at.23.34.42.mov
@jakeett jakeett added the type_bug Something isn't working label Jun 10, 2024
@matthew-carroll matthew-carroll added area_supereditor Pertains to SuperEditor platform_ios Applies to use on iOS platform_android Applies to use on Android bounty_junior area_super_reader Related to SuperReader f:clickup time:2 labels Jun 11, 2024
@matthew-carroll
Copy link
Contributor

@jakeett what's the expected behavior here? Are you saying that when you start dragging horizontally, the editor shouldn't ever move vertically no matter how far up/down you move your finger?

If so, can you please include a video of some other iOS app with a document that behaves the way you describe?

@jakeett
Copy link
Author

jakeett commented Jun 18, 2024

No sorry, I am saying that horizontal drag gestures should not be mapped to vertical scroll movements. In the video I was trying to demonstrate that when you scroll left/right, then the screen is getting scrolled vertically. Also, when the user initiates a horizontal drag gesture, then all vertical movement is getting ignored.

I have taken some videos with clicks highlighted, hopefully that makes it a bit clearer to see.

Current behaviour Expected behaviour
Screen.Recording.2024-06-18.at.08.56.44.mov
Screen.Recording.2024-06-18.at.08.58.48.mov

Also this doesn't happen on android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area_super_reader Related to SuperReader area_supereditor Pertains to SuperEditor bounty_junior f:clickup platform_android Applies to use on Android platform_ios Applies to use on iOS time:2 type_bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants