Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CollectingResponse inconsistency with actual response types #975

Open
porcellus opened this issue Jan 22, 2025 · 0 comments
Open

CollectingResponse inconsistency with actual response types #975

porcellus opened this issue Jan 22, 2025 · 0 comments

Comments

@porcellus
Copy link
Collaborator

In our guides we recommend people to implement sending custom responses in API overrides by calling sendJSONResponse on the response class and that the object returned by the override will be ignored.
This doesn't work in the current implementation since later calls to sendJSONResponse (from a non-overrideable part of the SDK) will actually overwrite the response set in the override instead of simulating what other response types do, where the later calls to sendJSONResponse are ignored.
This is causing issues in our in NextJS integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant