Support to Tumblr elements #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 30, 2014 21:42
Added .not( ".post *" ) to line number 197. ".post" is the class for the "article" items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a .not() selector to your plugin but it must be inlcuded in the options. (I am not able to do that unfortunatelly).
The .not selector is useful not to select some elements, especially on tumblr themes. On tumblr themes there are some elements that it is better not to touch and this plugin touches these elements. You cound add an option like
ignore: undefinedwhich will be defined later on the options. Unfortunatelly I am not able to add this feature to your plugin but I (and all tumblr themes designers) will be grateful. Your plugin is the only one that works!!