Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to make digits orientation to vertical ? #3

Open
1903514970 opened this issue Mar 6, 2019 · 4 comments
Open

how to make digits orientation to vertical ? #3

1903514970 opened this issue Mar 6, 2019 · 4 comments

Comments

@1903514970
Copy link

I‘v changed digits “isRotated = true" in MongolTextLine.java,the numbers became vertical but not perform
well. How to make digit's orientation to vertical and performs well ?

@suragch
Copy link
Owner

suragch commented Mar 6, 2019

What do you mean by "not perform well"? Is it slow? Does it make other characters rotate wrong? What is the specific problem?

Did you add an if statement to check for digits in the isRotated(int codePoint) method?

I've also thought about rotating digits in the past, but I didn't know what was standard. For example, single digit like 1 or 8 would be good if they were rotated. But what about 2 digit numbers like 10 or 43? Or longer numbers like phone numbers or years? What is the general expected behavior?

@1903514970
Copy link
Author

thanks for your reply. Yeah,I have add an if statement, and I only want one digit number to vertical。here is the gif. there is a problem that some of numbers are not visible,they just go down but I want them change line.
1551922062284

@suragch
Copy link
Owner

suragch commented Mar 7, 2019

Thank you. That is clear. Somehow the view size is not getting measured correctly. I'll look into when I have some time. If you find the problem first, let me know.

I'm guessing that it would be a relatively simple fix to make all numbers rotated. If you only want to rotate single digits but not multi digits, that may be more difficult.

@1903514970
Copy link
Author

OK,thanks for your patient reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants