[Bug] Syntax Errors in VPC package

[amalmadhu06]

Description

Syntax error in the VPC package. Also, naming the package as VPC is causing case insensitive import collision

Screenshots

Additional information

No response

[amalmadhu06]

Hi @gawandepratik022
If you have some time to check this and make the necessary fixes, it would be greatly appreciated. Otherwise, I can try to address the issue.

[amalmadhu06]

I'm working on this

[riteshsonawane1372]

@amalmadhu06 kindly have a look at the code https://replit.com/@riteshsonawane/FirstCyanCodec#getVPC.go

[riteshsonawane1372]

Have a look at this repo https://github.com/omsonawane1372/awsctl I ran the build and test workflow.

[amalmadhu06]

Hi @riteshsonawane1372 .
go test ./ will only check files in the current directory. I think we need to use go test ./...
I can see that go build is working.

I have tried to fix the syntax issues from the vpc package. Please see this pull request in my fork : amalmadhu06#1

Unfortunately, ci is again failing. Not sure what's going wrong.

[riteshsonawane1372]

Hi @riteshsonawane1372 . go test ./ will only check files in the current directory. I think we need to use go test ./... I can see that go build is working.

I have tried to fix the syntax issues from the vpc package. Please see this pull request in my fork : amalmadhu06#1

Unfortunately, ci is again failing. Not sure what's going wrong.

The changes in the PR won't fix the issue. Check this repo https://github.com/omsonawane1372/awsctl
Copy the pkg/VPC/getVPC.go and cmd/vpc to ur repo

[riteshsonawane1372]

The golangci-lint will cause problems bcoz we have mentioned *&x in some part of the code, So to run this workflow we need to change *&x to x

[amalmadhu06]

If possible, can you please take up this issue @riteshsonawane1372 ? I'm a bit confused here.

[riteshsonawane1372]

If possible, can you please take up this issue @riteshsonawane1372 ? I'm a bit confused here.

Just do below changes and if it doesn't work I will work on this issue:

1. Copy code from pkg/VPC/getVPC.go (repo : https://github.com/omsonawane1372/awsctl) paste it in ur repo.
2. Copy code from cmd/vpc and paste it.
3. Build locally and test it, you can run $ make to build binary and run it using ./awsctl get vpc

[riteshsonawane1372]

@amalmadhu06 I have open a PR ( #51 ) which will solve the worflow related issue.
I ran all the workflows under https://github.com/omsonawane1372/awsctl/ Below is the result.

[amalmadhu06]

Thankyou @riteshsonawane1372
Really appreciate your efforts ❤️