Language code casing issue with Chinese

[yannjor]

Describe the bug

The Chinese language codes seem to be set to zh-cn and zh-tw for simplified and traditional characters respectively.

survey-library/packages/survey-core/src/localization/simplified-chinese.ts

Line 242 in d09e8b3

setupLocale({ localeCode: "zh-cn", strings: simplifiedChineseSurveyStrings, nativeName: "简体中文", englishName: "Simplified Chinese" });

Setting:

const survey = new Model(surveyJson);
survey.locale = "zh-CN"

Doesn't seem to work, and falls back to English translations. However I noticed for example this works.

survey.locale = "pt-BR"

Could this be a bug?

Thanks!

[JaneSjs]

Hi @yannjor,
You need to define the exact key such as "zh-cn". Would you please clarify why you tried setting the locale key as "zh-CN"?

[JaneSjs]

Take note that "pt-br" corresponds to the following localization dictionary: portuguese-br.
However, if you set "pt-BR", a survey will fallback to the portuguese.ts translation.

[yannjor]

Hey @JaneSjs,

Thanks for your answer! That makes sense. It's just that in our app we have a routing configuration where the locale prefixes have the "country part" in uppercase (pt-BR, zh-CN, etc). Solved this by simply converting to lower case when setting the SurveyModel locale.

But perhaps this could be made case insensitive.