Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with which-key #3

Open
link2xt opened this issue May 15, 2023 · 3 comments
Open

Compatibility with which-key #3

link2xt opened this issue May 15, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@link2xt
Copy link

link2xt commented May 15, 2023

I use which-key, and it displays possible continuations when I type C-c p-. But when I type , c p, I only see Devil: C-c p.

wesnel added a commit to wesnel/emacs-which-key that referenced this issue Aug 1, 2023
What is Devil?

"Devil mode trades your comma key in exchange for a modifier-free
editing experience in Emacs."

The above description comes from their README at:

https://github.com/susam/devil

Unfortunately, Devil is not currently supported by which-key. For
example, when I type `, x`, the which-key popup for `C-x` does not
appear. Instead, I merely see the following text in the echo area:

```
Devil: C-x
```

With this patch, I have mimicked the existing god-mode logic in
which-key to intercept the current Devil prompt and spawn a which-key
popup.

This feature was requested by susam/devil#3:

- susam/devil#3
wesnel added a commit to wesnel/emacs-which-key that referenced this issue Aug 1, 2023
What is Devil?

> Devil mode trades your comma key in exchange for a modifier-free
editing experience in Emacs.

The above description comes from their README at:

https://github.com/susam/devil

Unfortunately, Devil is not currently supported by which-key. For
example, when I type `, x`, the which-key popup for `C-x` does not
appear. Instead, I merely see the following text in the echo area:

```
Devil: C-x
```

With this patch, I have mimicked the existing god-mode logic in
which-key to intercept the current Devil prompt and spawn a which-key
popup.

This feature was requested by susam/devil#3:

- susam/devil#3
wesnel added a commit to wesnel/emacs-which-key that referenced this issue Aug 1, 2023
What is Devil?

> Devil mode trades your comma key in exchange for a modifier-free
editing experience in Emacs.

The above description comes from their README at:

https://github.com/susam/devil

Unfortunately, Devil is not currently supported by which-key. For
example, when I type `, x`, the which-key popup for `C-x` does not
appear. Instead, I merely see the following text in the echo area:

```
Devil: C-x
```

With this patch, I have mimicked the existing god-mode logic in
which-key to intercept the current Devil prompt and spawn a which-key
popup.

This feature was requested by susam/devil#3:

- susam/devil#3
@wesnel
Copy link

wesnel commented Aug 1, 2023

hey! i made a pull request at justbur/emacs-which-key#353 which should hopefully add support for devil in which-key.

if you want to use my changes before that pull request is merged, you can use whatever your preferred method is to download and use the wesnel/add-devil-support branch of my fork of which-key.

https://github.com/wesnel/emacs-which-key/tree/wesnel/add-devil-support

@AkibAzmain
Copy link

@wesnel LGTM!

wesnel added a commit to wesnel/emacs-which-key that referenced this issue Oct 24, 2023
What is Devil?

> Devil mode trades your comma key in exchange for a modifier-free
editing experience in Emacs.

The above description comes from their README at:

https://github.com/susam/devil

Unfortunately, Devil is not currently supported by which-key. For
example, when I type `, x`, the which-key popup for `C-x` does not
appear. Instead, I merely see the following text in the echo area:

```
Devil: C-x
```

With this patch, I have mimicked the existing god-mode logic in
which-key to intercept the current Devil prompt and spawn a which-key
popup.

This feature was requested by susam/devil#3:

- susam/devil#3
@susam susam added the enhancement New feature or request label Oct 31, 2023
@fbrosda
Copy link

fbrosda commented Nov 9, 2024

Hi, first of all thanks for the original implementation. As it is unfortunately no longer compatible with the current which-key implementation I adapted it and added it to devil.el #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants