Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rfe] default bpf sample rate #1553

Open
jtaleric opened this issue Jun 18, 2024 · 1 comment
Open

[rfe] default bpf sample rate #1553

jtaleric opened this issue Jun 18, 2024 · 1 comment
Labels
kind/feature New feature or request

Comments

@jtaleric
Copy link

What would you like to be added?

We should consider dropping the sampling rate to EXPERIMENTAL_BPF_SAMPLE_RATE: 1000

We have seen decent improvement from the CPU utilization side when reducing the sampling rate.

Risk - We have not quantified the possible loss of granularity of the power data when enabling this, however when comparing to our redfish raw data it is still very close.
image

Why is this needed?

CPU usage reduction.

@jtaleric jtaleric added the kind/feature New feature or request label Jun 18, 2024
@dave-tucker
Copy link
Collaborator

We'll need to retest on main since #1481 has changed what's done before the sampling check in the eBPF code vs. what was done in the last released version. There might not be an appreciable difference in probe execution time with/without sampling set. I'll set up some micro-benchmarks to confirm once #1438 has gone in since that's blocking easier benchmarking/testing of the eBPF code.

@jtaleric jtaleric changed the title [ref] default bpf sample rate [rfe] default bpf sample rate Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants