Tidy fixes

Author: Mytherin

.clang-tidy

@@ -1,4 +1,4 @@
-Checks:          '-*,clang-diagnostic-*,bugprone-*,performance-*,google-explicit-constructor,google-build-using-namespace,google-runtime-int,misc-definitions-in-headers,modernize-use-nullptr,modernize-use-override,-bugprone-macro-parentheses,readability-braces-around-statements,-bugprone-branch-clone,readability-identifier-naming,hicpp-exception-baseclass,misc-throw-by-value-catch-by-reference,-bugprone-signed-char-misuse,-bugprone-misplaced-widening-cast,-bugprone-sizeof-expression,-bugprone-narrowing-conversions,-bugprone-easily-swappable-parameters,google-global-names-in-headers,llvm-header-guard,misc-definitions-in-headers,modernize-use-emplace,modernize-use-bool-literals,-performance-inefficient-string-concatenation,readability-container-size-empty'
+Checks:          '-*,clang-diagnostic-*,bugprone-*,performance-*,google-explicit-constructor,google-build-using-namespace,google-runtime-int,misc-definitions-in-headers,modernize-use-nullptr,modernize-use-override,-bugprone-macro-parentheses,readability-braces-around-statements,-bugprone-branch-clone,readability-identifier-naming,hicpp-exception-baseclass,misc-throw-by-value-catch-by-reference,-bugprone-signed-char-misuse,-bugprone-misplaced-widening-cast,-bugprone-sizeof-expression,-bugprone-narrowing-conversions,-bugprone-easily-swappable-parameters,google-global-names-in-headers,llvm-header-guard,misc-definitions-in-headers,modernize-use-emplace,modernize-use-bool-literals,-performance-inefficient-string-concatenation,-performance-no-int-to-ptr,readability-container-size-empty'
 WarningsAsErrors: '*'
 HeaderFilterRegex: '.*^(re2.h)'
 AnalyzeTemporaryDtors: false

src/common/types/value.cpp

@@ -72,6 +72,36 @@ Value::Value(string val) : type_(LogicalType::VARCHAR), is_null(false), str_valu
 Value::~Value() {
 }
 
+Value::Value(const Value &other)
+    : type_(other.type_), is_null(other.is_null), value_(other.value_), str_value(other.str_value),
+      struct_value(other.struct_value), list_value(other.list_value) {
+}
+
+Value::Value(Value &&other) noexcept
+    : type_(move(other.type_)), is_null(other.is_null), value_(other.value_), str_value(move(other.str_value)),
+      struct_value(move(other.struct_value)), list_value(move(other.list_value)) {
+}
+
+Value &Value::operator=(const Value &other) {
+	type_ = other.type_;
+	is_null = other.is_null;
+	value_ = other.value_;
+	str_value = other.str_value;
+	struct_value = other.struct_value;
+	list_value = other.list_value;
+	return *this;
+}
+
+Value &Value::operator=(Value &&other) noexcept {
+	type_ = move(other.type_);
+	is_null = other.is_null;
+	value_ = other.value_;
+	str_value = move(other.str_value);
+	struct_value = move(other.struct_value);
+	list_value = move(other.list_value);
+	return *this;
+}
+
 Value Value::MinimumValue(const LogicalType &type) {
 	switch (type.id()) {
 	case LogicalTypeId::BOOLEAN:

src/common/types/vector.cpp

@@ -1459,6 +1459,7 @@ vector<idx_t> ListVector::Search(Vector &list, const Value &key, idx_t row) {
 Value ListVector::GetValuesFromOffsets(Vector &list, vector<idx_t> &offsets) {
 	auto &child_vec = ListVector::GetEntry(list);
 	vector<Value> list_values;
+	list_values.reserve(offsets.size());
 	for (auto &offset : offsets) {
 		list_values.push_back(child_vec.GetValue(offset));
 	}

src/function/table/arrow.cpp

@@ -165,16 +165,12 @@ unique_ptr<FunctionData> ArrowTableFunction::ArrowScanBind(ClientContext &contex
                                                            vector<LogicalType> &input_table_types,
                                                            vector<string> &input_table_names,
                                                            vector<LogicalType> &return_types, vector<string> &names) {
-	auto stream_factory_ptr = inputs[0].GetPointer();
-	unique_ptr<ArrowArrayStreamWrapper> (*stream_factory_produce)(
+	typedef unique_ptr<ArrowArrayStreamWrapper> (*stream_factory_produce_t)(
 	    uintptr_t stream_factory_ptr,
 	    std::pair<std::unordered_map<idx_t, string>, std::vector<string>> & project_columns,
-	    TableFilterCollection * filters) =
-	    (unique_ptr<ArrowArrayStreamWrapper>(*)(uintptr_t stream_factory_ptr,
-	                                            std::pair<std::unordered_map<idx_t, string>, std::vector<string>> &
-	                                                project_columns,
-	                                            TableFilterCollection * filters)) inputs[1]
-	        .GetPointer();
+	    TableFilterCollection * filters);
+	auto stream_factory_ptr = inputs[0].GetPointer();
+	auto stream_factory_produce = (stream_factory_produce_t)inputs[1].GetPointer();
 	auto rows_per_thread = inputs[2].GetValue<uint64_t>();
 	std::pair<std::unordered_map<idx_t, string>, std::vector<string>> project_columns;
 #ifndef DUCKDB_NO_THREADS

src/include/duckdb/common/types.hpp

@@ -398,7 +398,7 @@ struct LogicalType {
 		return *this;
 	}
 	// move assignment
-	inline LogicalType& operator=(LogicalType&& other) {
+	inline LogicalType& operator=(LogicalType&& other) noexcept {
 		id_ = other.id_;
 		physical_type_ = other.physical_type_;
 		type_info_ = move(other.type_info_);

src/include/duckdb/common/types/value.hpp

@@ -44,9 +44,18 @@ class Value {
 	DUCKDB_API Value(string_t val); // NOLINT: Allow implicit conversion from `string_t`
 	//! Create a VARCHAR value
 	DUCKDB_API Value(string val); // NOLINT: Allow implicit conversion from `string`
+	//! Copy constructor
+	DUCKDB_API Value(const Value &other);
+	//! Move constructor
+	DUCKDB_API Value(Value &&other) noexcept;
 	//! Destructor
 	DUCKDB_API ~Value();
 
+	// copy assignment
+	DUCKDB_API Value &operator=(const Value &other);
+	// move assignment
+	DUCKDB_API Value &operator=(Value &&other) noexcept;
+
 	inline const LogicalType &type() const {
 		return type_;
 	}

src/storage/meta_block_writer.cpp

@@ -15,7 +15,13 @@ MetaBlockWriter::MetaBlockWriter(DatabaseInstance &db, block_id_t initial_block_
 }
 
 MetaBlockWriter::~MetaBlockWriter() {
-	Flush();
+	if (Exception::UncaughtException()) {
+		return;
+	}
+	try {
+		Flush();
+	} catch (...) {
+	}
 }
 
 block_id_t MetaBlockWriter::GetNextBlockId() {

tools/pythonpkg/src/include/duckdb_python/pyresult.hpp

@@ -50,7 +50,7 @@ struct DuckDBPyResult {
 
 	void Close();
 
-	static py::object GetValueToPython(Value &val, const LogicalType &type);
+	static py::object GetValueToPython(const Value &val, const LogicalType &type);
 
 private:
 	void FillNumpy(py::dict &res, idx_t col_idx, NumpyResultConversion &conversion, const char *name);

tools/pythonpkg/src/pyresult.cpp

@@ -33,7 +33,7 @@ void DuckDBPyResult::Initialize(py::handle &m) {
 	PyDateTime_IMPORT;
 }
 
-py::object DuckDBPyResult::GetValueToPython(Value &val, const LogicalType &type) {
+py::object DuckDBPyResult::GetValueToPython(const Value &val, const LogicalType &type) {
 	if (val.IsNull()) {
 		return py::none();
 	}