fix: strip ? from optional parameters (#35)

huntabyte · web-flow · commit 37ba69b24489 · 2025-06-27T12:16:06.000-04:00
diff --git a/.changeset/thick-dancers-jump.md b/.changeset/thick-dancers-jump.md
@@ -0,0 +1,6 @@
+---
+"@svecosystem/strip-types": patch
+---
+
+fix: strip `?` from optional parameters
+  
diff --git a/src/index.ts b/src/index.ts
@@ -76,6 +76,13 @@ export function strip(
 			}
 		}
 
+		// remove '?' from optional parameters
+		if (node.type === 'Identifier' && 'optional' in node && node.optional) {
+			// @ts-expect-error wrong
+			const questionMarkIndex = node.start + node.name.length;
+			src.update(questionMarkIndex, questionMarkIndex + 1, '');
+		}
+
 		// expressions that can just be removed outright
 		const tsNodes = [
 			'TSTypeParameterInstantiation',
diff --git a/tests/cases/optional-params/js.svelte b/tests/cases/optional-params/js.svelte
@@ -0,0 +1,3 @@
+<script>
+	function scrollTo(index, jump) {}
+</script>
diff --git a/tests/cases/optional-params/ts.svelte b/tests/cases/optional-params/ts.svelte
@@ -0,0 +1,3 @@
+<script lang="ts">
+	function scrollTo(index: number, jump?: boolean) {}
+</script>

-Original file line number
+Diff line change
@@ @@ -0,0 +1,6 @@ @@
 +---
 +"@svecosystem/strip-types": patch
 +---
++
 +fix: strip `?` from optional parameters
++
Original file line number	Diff line number	Diff line change
`@@ -76,6 +76,13 @@ export function strip(`
`76`	`76`	`}`
`77`	`77`	`}`
`78`	`78`
	`79`	`+ // remove '?' from optional parameters`
	`80`	`+ if (node.type === 'Identifier' && 'optional' in node && node.optional) {`
	`81`	`+ // @ts-expect-error wrong`
	`82`	`+ const questionMarkIndex = node.start + node.name.length;`
	`83`	`+ src.update(questionMarkIndex, questionMarkIndex + 1, '');`
	`84`	`+ }`
	`85`	`+`
`79`	`86`	`// expressions that can just be removed outright`
`80`	`87`	`const tsNodes = [`
`81`	`88`	`'TSTypeParameterInstantiation',`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+<script>`
	`2`	`+ function scrollTo(index, jump) {}`
	`3`	`+</script>`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+<script lang="ts">`
	`2`	`+ function scrollTo(index: number, jump?: boolean) {}`
	`3`	`+</script>`