Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration changes unnecessary lines #364

Open
mig-hub opened this issue Dec 18, 2024 · 2 comments
Open

Migration changes unnecessary lines #364

mig-hub opened this issue Dec 18, 2024 · 2 comments
Labels
bug Something isn't working pkg:add sv add

Comments

@mig-hub
Copy link

mig-hub commented Dec 18, 2024

I know it is minor, but the migration script to svelte-5 changes unnecessary lines.

e.g.

{#if title?.length }

Becomes:

{#if title?.length}

Note the space removed before the closing curly bracket.

I know this space might not be the current coding style but I personally like it that way. And the point is that the script should not change a line if it is functionally correct. Otherwise it makes the git commit bigger for nothing.

@manuel3108
Copy link
Member

Relates to #118

@manuel3108 manuel3108 added bug Something isn't working pkg:add sv add labels Dec 23, 2024
@manuel3108
Copy link
Member

Out of interest - are you using any code formatting tools and if so, is there a way to make them aware of such stuff?

Because this might potentially be a very niche use-case where i'm not sure if we should handle that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:add sv add
Projects
None yet
Development

No branches or pull requests

2 participants