Skip to content

Commit 4e45ffa

Browse files
committed
update note to self
1 parent 8f8de50 commit 4e45ffa

File tree

1 file changed

+3
-3
lines changed
  • packages/svelte/src/internal/client/dom/blocks

1 file changed

+3
-3
lines changed

packages/svelte/src/internal/client/dom/blocks/each.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -535,13 +535,13 @@ function reconcile(each_effect, array, state, anchor, flags, get_key) {
535535
});
536536
}
537537

538+
// TODO i have an inkling that the rest of this function is wrong...
539+
// the offscreen items need to be linked, so that they all update correctly.
540+
// the last onscreen item should link to the first offscreen item, etc
538541
each_effect.first = state.first && state.first.e;
539542
each_effect.last = prev && prev.e;
540543

541544
if (prev) {
542-
// TODO i think this is wrong... the offscreen items need to be linked,
543-
// so that they all update correctly. the last onscreen item should link
544-
// to the first offscreen item, etc
545545
prev.e.next = null;
546546
}
547547
}

0 commit comments

Comments
 (0)