-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Svelte 5: List of libraries not working out of the box #10359
Comments
|
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@mstachowiak what doesn't work exactly here? #8301 is present in Svelte 4 as well. The library should work since it sets the |
This comment was marked as resolved.
This comment was marked as resolved.
Adjusts the escaping mechanism done for server compilation. For template literals it's now only applied when explicitly told, which is the case for generated literals from the html template. Fixes a bug where a template literal string inside the `@html` tag was wrongfully escaped (#10359 (comment))
Adjusts the escaping mechanism done for server compilation. For template literals it's now only applied when explicitly told, which is the case for generated literals from the html template. Fixes a bug where a template literal string inside the `@html` tag was wrongfully escaped (#10359 (comment))
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
It seems like a ton of libraries are using |
TanStack/table#5213. The svelte wrapper for TanStack Table is using |
This comment was marked as resolved.
This comment was marked as resolved.
svelteflow.dev - the following error occurs as soon as the dep is installed
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
* fix: handle component binding mutation #10359 (comment) * alternative approach to mutating props (#10788) Co-authored-by: Rich Harris <[email protected]> --------- Co-authored-by: Rich Harris <[email protected]> Co-authored-by: Rich Harris <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
|
From the linked issue it sounds like you're setting |
Yeah, I did that, but I decided to come at it from the other angle and, following the advice from here, turned rune mode on for the entire app and turned it off for the individual incompatible library.
I think it would be helpful to have this info in the documentation. |
This comment was marked as resolved.
This comment was marked as resolved.
In edge cases it may happen that set_attributes is re-run before the effect is executed. In that case the render effect which initiates this re-run will destroy the inner effect and it will never run. But because next and prev may have the same keys, the event would not get added again and it would get lost. We prevent this by using a root effect. The added test case doesn't fail for some reason without this fix, but it does fail when you test it out manually, so I still added it. Found through #10359 (comment)
In edge cases it may happen that set_attributes is re-run before the effect is executed. In that case the render effect which initiates this re-run will destroy the inner effect and it will never run. But because next and prev may have the same keys, the event would not get added again and it would get lost. We prevent this by using a root effect. The added test case doesn't fail for some reason without this fix, but it does fail when you test it out manually, so I still added it. Found through #10359 (comment)
This comment was marked as resolved.
This comment was marked as resolved.
I just ran LayerChart's docs using the latest Svelte 5 (5.0.0-next.144 as of writing this) and it was experiencing quite a few problems (all dialogs open by default, non reactive toggles, 100% CPU on some pages, etc). Some of these are likely coming from Svelte UX components as well (which has been pretty good to tease out regressions). I'll be investigating these as I get time and hopefully create minimal REPL reproductions when possible, but wanted to give a heads up in case someone else has time to take a look. I did just log an SVG namespace issue (#11847) that was uncovered. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This can be marked as fixed. For now, the fix only exists in the |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Wow that was fast @dummdidumm! I updated both Strava and Github analysis and that does appear to fix this issue. I'm seeing some other issues but I'll investigate and report separately (mostly with a specific chart in Strava Analysis). CleanShot.2024-06-19.at.15.01.16.2.mp4Have to run out the door now though. |
Threlte also throws the error of importing from "svelte/internal". I don't know if this should be commented here as of today, let me know if I should move/coment elsewhere! Thanks in advance! Minimal reproduction error is to simply install it and use a scene, like in their "Your First Scene" page. Importing the component alone already triggers the error <script lang="ts">
import { Canvas } from '@threlte/core'
</script>
<div>
:(
</div>
|
There is no |
@7nik understood. thanks for clarifying! |
For any Threlte users coming here, there is a |
Describe the bug
Some libraries don't work with Svelte 5 out of the box. It will probably be impossible to make every library compatible given that some use stuff
svelte/internal
(which they really shouldn't) and everything in there changed, but those who don't should be closely investigated. Feel free to post libraries you found that don't work in here, ideally along with a small reproduction (repro or "install and use component X").To investigate
svelte-turnstile
Won't / can't fix
svelte/internal
in a way that can't be backported Svelte 5 support: ERROR: No matching export in "a" for import "b" TanStack/table#5213 - but a new version of the library is underway with Svelte 5 support!Fixed
svelte-confetti
svelte-range-slider-pips
(through fix: better interop of$state
with actions/$:
statements #10543)Reproduction
Use the libraries and observe errors
Logs
No response
System Info
Severity
annoyance
The text was updated successfully, but these errors were encountered: