read_pattern fails if brackets are in strings etc

[Rich-Harris]

Describe the bug

At a couple of places during parsing, we need to skip ahead to figure out what to feed Acorn — inside read_pattern, and as of #12070 inside snippets using a separate mechanism. The logic fails if characters like { appear inside strings, comments or regular expressions and are not balanced:

<!-- ok -->
{#each x as { y = 'z' }}{/each}

<!-- not ok -->
{#each x as { y = '{' }}{/each}

Reproduction

link

Logs

No response

System Info

next

Severity

annoyance

[paoloricciuti]

Speaking of which it just occured to me: right now if the function parsing fail we just silently fail...we should probably throw (same for unbalanced parentheses) right?

Currently is possible to do something like this. Should I open a new issue?

[Rich-Harris]

Ah yep, that definitely warrants an issue. Good catch