-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sv check
should not warn about non-reactive code when runes are disabled
#14034
Comments
This is actually a warning for non runes mode because if you import something and access it and use it in a labeled statement that thing it's not reactive |
I'm wondering how much use this warning is / how many false positives it yields. |
tbf i don't think people are importing stuff expecting it to be reactive but overall i'm more inclined to mute a warning than have false negatives...i wonder if there's some github search we can do to check 🤔 |
#13811 is sort of related I think it's a little bit weird to add new warnings for non-runes code because this code was typically working in Svelte 4 and so now you have to go back and add ignores for code that you already know was working. It makes more sense in the context where you're writing new code, but it's a little less clear is valuable when it's on legacy code that you're going to migrate anyway and don't want to spend time cleaning up other than migrating it |
It sounds like the vast majority of people are either confused by this warning or annoyed and silence it. We should remove it |
Describe the bug
I am using
sv check
with a code base that uses Svelte 5, but non-runes mode. I disabled runes in mysvelte.config.js
using thecompilerOptions: { runes : false }
setting.However I still get the warnings "Warn: Properties of objects and arrays are not reactive unless in runes mode...."
Reproduction
compilerOptions: { runes : false }
setting insvelte.config.js
.$:
statement.sv check
Logs
Severity
annoyance
The text was updated successfully, but these errors were encountered: