Skip to content

Commit 6c83091

Browse files
Merge pull request #226 from swamphacks/dev
Hotfix: Modal overflow for review assignees
2 parents 51ccc0c + 4b489ac commit 6c83091

2 files changed

Lines changed: 24 additions & 20 deletions

File tree

‎apps/web/src/features/ApplicationReview/components/ReviewNotStarted/ReviewerAssignmentModal.tsx‎

Lines changed: 21 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -70,27 +70,29 @@ export default function ReviewerAssignmentModal({
7070

7171
return (
7272
<Modal>
73-
<div className="flex flex-col">
73+
<div className="flex flex-col max-h-full sm:max-h-[90vh]">
7474
<h2>Select Reviewers</h2>
75+
<div className="flex-3 overflow-auto mt-2">
76+
<ReviewerList
77+
staff={staff}
78+
assigned={assigned}
79+
setAssigned={setAssigned}
80+
/>
81+
</div>
82+
<div className="mt-4 flex gap-2 flex-col flex-1">
83+
<SummaryFooter
84+
numAssigned={numAssigned}
85+
total={stats.status_stats.submitted}
86+
/>
7587

76-
<ReviewerList
77-
staff={staff}
78-
assigned={assigned}
79-
setAssigned={setAssigned}
80-
/>
81-
82-
<SummaryFooter
83-
numAssigned={numAssigned}
84-
total={stats.status_stats.submitted}
85-
/>
86-
87-
<div className="mt-4 flex justify-end gap-2">
88-
<Button slot="close" variant="secondary">
89-
Cancel
90-
</Button>
91-
<Button variant="primary" onClick={handleSubmit}>
92-
Assign Reviewers
93-
</Button>
88+
<div className="flex flex-row w-full justify-end gap-2">
89+
<Button className="w-fit" slot="close" variant="secondary">
90+
Cancel
91+
</Button>
92+
<Button className="w-fit" variant="primary" onClick={handleSubmit}>
93+
Assign Reviewers
94+
</Button>
95+
</div>
9496
</div>
9597
</div>
9698
</Modal>

‎apps/web/src/features/ApplicationReview/components/ReviewNotStarted/ReviewerList.tsx‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,9 @@ export default function ReviewerList({ staff, assigned, setAssigned }: Props) {
5555
<Checkbox value={s.id} className="flex-1">
5656
<div className="flex flex-row items-center gap-2">
5757
<span>{s.name || "Anonymous"}</span>
58-
<span className="text-xs text-text-secondary">{s.email}</span>
58+
<span className="text-xs text-text-secondary hidden sm:block">
59+
{s.email}
60+
</span>
5961
</div>
6062
</Checkbox>
6163

0 commit comments

Comments
 (0)