Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We contradict our own advice about forgetting about ssh keys #950

Open
maneesha opened this issue Aug 10, 2023 · 2 comments
Open

We contradict our own advice about forgetting about ssh keys #950

maneesha opened this issue Aug 10, 2023 · 2 comments
Labels
status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR

Comments

@maneesha
Copy link
Contributor

What is the problem?

In the section about keeping ssh keys secure, first we say that you can set it and forget it, but immediately after we have a callout that says you shouldn't forget about your ssh keys because they keep your account secure.

We should clarify this language to make it less confusing.

Location of problem (optional)

https://swcarpentry.github.io/git-novice/07-github.html#keeping-your-keys-secure

@martinosorb
Copy link
Contributor

I think this was done on purpose. It says "you can forget..." but then the callout says "...but don't actually", and it's a callout because this is more of a detail. Would it help if it said "you shouldn't actually forget...", so that it's clear we are purposefully referencing the previous sentence?

@martinosorb martinosorb added the status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR label Jul 2, 2024
@maneesha
Copy link
Contributor Author

maneesha commented Oct 8, 2024

I think this can be confusing to a novice learner, to say "You can forget it, but don't really forget it." More explicit language may be more useful here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR
Projects
None yet
Development

No branches or pull requests

2 participants