Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detecting Emoji Type #5

Open
jalcine opened this issue Mar 21, 2019 · 1 comment
Open

Detecting Emoji Type #5

jalcine opened this issue Mar 21, 2019 · 1 comment

Comments

@jalcine
Copy link

jalcine commented Mar 21, 2019

Side-note: This project just saved me hours of porting TwitterText into Elixir; thank you!

I've looked at the regex and it looks like handling emoji type (:emoji:) is pretty feasible. How open are you to a PR for that? It could be up to the caller to do whatever with the resulting text - so no need to do actual emoji lookups (and allow for users to define 'custom' emoji).

@swelham
Copy link
Owner

swelham commented Mar 21, 2019

Hi @jalcine, I am pleased to hear you were able to save some time!

I am always open to a PR, the one thing I will note is this project was a learning tool for me originally and maybe doesn't carry out it's function in the most efficient way 🙂. It uses pattern matching whilst recursing over a string instead of regex but what you look to achieve is totally possible I believe.

Please feel free to put in a PR and I will be more than happy to look over it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants