Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple same qualifiers of same type? #37

Closed
zvr opened this issue Oct 2, 2023 · 3 comments
Closed

Multiple same qualifiers of same type? #37

zvr opened this issue Oct 2, 2023 · 3 comments

Comments

@zvr
Copy link
Contributor

zvr commented Oct 2, 2023

The specification does not currently say anything about restricting qualifiers to single appearance.

For example, can a single SWHID have two origin qualifiers?

Do we need some wording that each one appears at maximum once? Or some of them, and other may appear multiple times?

@zacchiro
Copy link
Contributor

zacchiro commented Oct 4, 2023

Nice catch, thanks

Conceptually: we have always considered each qualifier to be unique, and not to be repeated.

In terms of formal specification, I think that at some point we were sort-of-convinced that the SWHID URI-based syntax was implicitly excluding parameter repetition.
But I'm no longer sure about that (and I haven't double checked).

And in any event I think it would be much better to state explicitly that qualifiers must not be repeated.

@rdicosmo
Copy link
Contributor

rdicosmo commented Oct 4, 2023

Indeed, very good point! The current grammar allows repeated qualifiers, see:

<qualifiers> := ";" <qualifier> [ <qualifiers> ] ;
<qualifier> ::=
<context_qualifier>
| <fragment_qualifier>
;

#38 clarifies that each qualifier can occur at most once.

@rdicosmo
Copy link
Contributor

This is now addressed in #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants