Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpgsig in git can also be SSH signature instead of OpenGPG #48

Closed
castedo opened this issue Oct 23, 2023 · 4 comments
Closed

gpgsig in git can also be SSH signature instead of OpenGPG #48

castedo opened this issue Oct 23, 2023 · 4 comments

Comments

@castedo
Copy link
Contributor

castedo commented Oct 23, 2023

- extra headers (ordered list of byte key/value pairs): arbitrary additional metadata attached to the revision. The key must not contain the ASCII bytes for the space or LF characters; commonly used keys are a string of non-whitespace printable ASCII characters, such as `"encoding"` (where the value is interpreted as the encoding of the message field) or `"gpgsig"` (where the value is interpreted as an OpenPGP signature of the metadata of the revision).

This line reads or "gpgsig" (where the value is interpreted as an OpenPGP signature of the metadata of the revision). However, the gpgsig is a bit of a misnomer now in that the signature can be SSH or x509 signatures too. See https://git-scm.com/docs/gitformat-signature

Perhaps better to just say a "cryptographic signature" rather than "OpenPGP signature".

@zacchiro
Copy link
Contributor

PR welcome!

@castedo
Copy link
Contributor Author

castedo commented Oct 24, 2023

OK, sounds good. I will do a PR.

@zacchiro I am torn between

a tiny teeny change: an OpenPGP signature of -> a cryptographic signature of

VS

a bigger change: an OpenPGP signature of -> an ASCII armor encoded cryptographic signature of

Any thoughts?

I am inclined to go for the bigger one.

@zacchiro
Copy link
Contributor

It's an example, so I don't think it matters much which one. But for what is worth I like the first one more, because it's easier to read/understand for the intended public.

@rdicosmo
Copy link
Contributor

Merged #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants