Skip to content

Commit 149e5d1

Browse files
committed
Address PR feedback
1 parent 95495dc commit 149e5d1

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

.github/workflows/scripts/install-and-build-with-sdk.sh

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -436,44 +436,44 @@ STATIC_LINUX_SDK_DOWNLOAD_ROOT="${SWIFT_DOWNLOAD_ROOT}/${SWIFT_VERSION_BRANCH}/s
436436
WASM_SDK_DOWNLOAD_ROOT="${SWIFT_DOWNLOAD_ROOT}/${SWIFT_VERSION_BRANCH}/wasm-sdk"
437437

438438
install_static_linux_sdk() {
439-
# Check if the static SDK is already installed
439+
# Check if the Static Linux Swift SDK is already installed
440440
if "$SWIFT_EXECUTABLE_FOR_STATIC_LINUX_SDK" sdk list 2>/dev/null | grep -q "^${STATIC_LINUX_SDK_TAG}_static-linux-0.0.1"; then
441-
log "✅ Static SDK ${STATIC_LINUX_SDK_TAG} is already installed, skipping installation"
441+
log "✅ Static Linux Swift SDK ${STATIC_LINUX_SDK_TAG} is already installed, skipping installation"
442442
return 0
443443
fi
444444

445-
log "Installing Swift Static SDK: $STATIC_LINUX_SDK_TAG"
445+
log "Installing Static Linux Swift SDK: $STATIC_LINUX_SDK_TAG"
446446

447447
local static_linux_sdk_filename="${STATIC_LINUX_SDK_TAG}_static-linux-0.0.1.artifactbundle.tar.gz"
448448
local sdk_url="${STATIC_LINUX_SDK_DOWNLOAD_ROOT}/${STATIC_LINUX_SDK_TAG}/${static_linux_sdk_filename}"
449449

450450
log "Running: ${SWIFT_EXECUTABLE_FOR_STATIC_LINUX_SDK} sdk install ${sdk_url} --checksum ${STATIC_LINUX_SDK_CHECKSUM}"
451451

452452
if "$SWIFT_EXECUTABLE_FOR_STATIC_LINUX_SDK" sdk install "$sdk_url" --checksum "$STATIC_LINUX_SDK_CHECKSUM"; then
453-
log "✅ Static SDK installed successfully"
453+
log "✅ Static Linux Swift SDK installed successfully"
454454
else
455-
fatal "Failed to install static SDK"
455+
fatal "Failed to install Static Linux Swift SDK"
456456
fi
457457
}
458458

459459
install_wasm_sdk() {
460-
# Check if the Wasm SDK is already installed
460+
# Check if Swift SDK for Wasm is already installed
461461
if "$SWIFT_EXECUTABLE_FOR_WASM_SDK" sdk list 2>/dev/null | grep -q "^${WASM_SDK_TAG}_wasm"; then
462-
log "Wasm SDK ${WASM_SDK_TAG} is already installed, skipping installation"
462+
log "Swift SDK for Wasm ${WASM_SDK_TAG} is already installed, skipping installation"
463463
return 0
464464
fi
465465

466-
log "Installing Swift Wasm SDK: $WASM_SDK_TAG"
466+
log "Installing Swift SDK for Wasm: $WASM_SDK_TAG"
467467

468468
local wasm_sdk_filename="${WASM_SDK_TAG}_wasm.artifactbundle.tar.gz"
469469
local sdk_url="${WASM_SDK_DOWNLOAD_ROOT}/${WASM_SDK_TAG}/${wasm_sdk_filename}"
470470

471471
log "Running: ${SWIFT_EXECUTABLE_FOR_WASM_SDK} sdk install ${sdk_url} --checksum ${WASM_SDK_CHECKSUM}"
472472

473473
if "$SWIFT_EXECUTABLE_FOR_WASM_SDK" sdk install "$sdk_url" --checksum "$WASM_SDK_CHECKSUM"; then
474-
log "Wasm SDK installed successfully"
474+
log "Swift SDK for Wasm installed successfully"
475475
else
476-
fatal "Failed to install Wasm SDK"
476+
fatal "Failed to install Swift SDK for Wasm"
477477
fi
478478
}
479479

@@ -491,7 +491,7 @@ install_sdks() {
491491

492492
build() {
493493
if [[ "$INSTALL_STATIC_LINUX" == true ]]; then
494-
log "Running Swift build with static SDK"
494+
log "Running Swift build with Static Linux Swift SDK"
495495

496496
local sdk_name="${STATIC_LINUX_SDK_TAG}_static-linux-0.0.1"
497497
local build_command="$SWIFT_EXECUTABLE_FOR_STATIC_LINUX_SDK build --swift-sdk $sdk_name"
@@ -502,14 +502,14 @@ build() {
502502
log "Running: $build_command"
503503

504504
if eval "$build_command"; then
505-
log "✅ Swift build with static SDK completed successfully"
505+
log "✅ Swift build with Static Linux Swift SDK completed successfully"
506506
else
507-
fatal "Swift build with static SDK failed"
507+
fatal "Swift build with Static Linux Swift SDK failed"
508508
fi
509509
fi
510510

511511
if [[ "$INSTALL_WASM" == true ]]; then
512-
log "Running Swift build with Wasm SDK"
512+
log "Running Swift build with Swift SDK for Wasm"
513513

514514
if [[ "$BUILD_EMBEDDED_WASM" == true ]]; then
515515
local sdk_name="${WASM_SDK_TAG}_wasm-embedded"

0 commit comments

Comments
 (0)