From 0c7a0ce9f265c6192dcd5858d790c70f6d9a7562 Mon Sep 17 00:00:00 2001 From: Franz Busch Date: Thu, 31 Jul 2025 15:04:12 +0200 Subject: [PATCH 1/2] Enable the api breaking check to work for private repos MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit # Motivation Currently, the API breaking check is not working for private repos since it requires git credentials to be configured so that it can clone the repo again # Modifications This sets the `persist-credentials` to `true` for only the diagnose API breaking checks job since that one has a credible need to re-use the git credentials # Result API breaking change checking now works for private repos --- .github/workflows/soundness.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/soundness.yml b/.github/workflows/soundness.yml index 54fa5f5a..29ebfea8 100644 --- a/.github/workflows/soundness.yml +++ b/.github/workflows/soundness.yml @@ -97,7 +97,10 @@ jobs: - name: Checkout repository uses: actions/checkout@v4 with: - persist-credentials: false + # This is set to true since swift package diagnose-api-breaking-changes is + # cloning the repo again and without it being set to true this job won't work for + # private repos. + persist-credentials: true submodules: true fetch-tags: true fetch-depth: 0 # Fetching tags requires fetch-depth: 0 (https://github.com/actions/checkout/issues/1471) From 1ca747e8b3f6f928953da4b6857214e7305e924b Mon Sep 17 00:00:00 2001 From: Franz Busch Date: Thu, 31 Jul 2025 16:03:04 +0200 Subject: [PATCH 2/2] Update soundness.yml --- .github/workflows/soundness.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/soundness.yml b/.github/workflows/soundness.yml index 29ebfea8..6c7d187b 100644 --- a/.github/workflows/soundness.yml +++ b/.github/workflows/soundness.yml @@ -100,7 +100,7 @@ jobs: # This is set to true since swift package diagnose-api-breaking-changes is # cloning the repo again and without it being set to true this job won't work for # private repos. - persist-credentials: true + persist-credentials: true submodules: true fetch-tags: true fetch-depth: 0 # Fetching tags requires fetch-depth: 0 (https://github.com/actions/checkout/issues/1471)