Use new Swift Build run destination API for SDK's #9527
Merged
+114
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using an SDK with the `--swift-sdk` build parameter this information is provided to Swift Build as part of the build request so that it can use it instead of the host SDK.
…ager into sdk_experimental
Member
Author
|
@swift-ci please test |
| platformName = "android" | ||
| sdkName = platformName | ||
| // FIXME remove this case | ||
| } else if self.buildParameters.triple.isWasm { |
Contributor
There was a problem hiding this comment.
I think you can just remove this now, it's unreachable code.
cmcgee1024
requested review from
bkhouri,
bripeticca,
daveyc123,
dschaefer2,
owenv,
plemarquand and
rconnell9
as code owners
…ager into sdk_experimental
Member
Author
|
@swift-ci please test |
Contributor
|
@swift-ci test windows |
Member
Author
|
@swift-ci test Windows |
1 similar comment
Member
Author
|
@swift-ci test Windows |
Contributor
|
@swift-ci test windows |
owenv
approved these changes
Jan 20, 2026
| verboseFlag // clang will be invoked to link so the verbose flag is valid for it | ||
| + inherited | ||
|
|
||
| otherLdFlags += buildParametersLinkFlags |
Contributor
There was a problem hiding this comment.
Unless there's a specific reason to order it this way we usually prefer to put $(inherited) at the end of the list
Member
Author
There was a problem hiding this comment.
I'll do this in a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an SDK with the
--swift-sdkbuild parameter this information is provided to Swift Build as part of the build request so that it can use it instead of the host SDK.